ref(api): Segment API endpoints#13941
Merged
Merged
Conversation
wedamija
reviewed
Jul 10, 2019
wedamija
left a comment
wedamija
left a comment
Member
There was a problem hiding this comment.
Looks good in general, probably need to test with getsentry as well just to be sure?
| ), | ||
|
|
||
| # Incidents | ||
| url( |
Member
There was a problem hiding this comment.
Does it make sense to include incidents as a sub pattern? ( I assume you can have ^(?P<organization_slug>[^\/]+)/incidents/ as another level)
Member
Author
There was a problem hiding this comment.
Yeah we could totally do more levels I think. I just didn't.
Member
Author
|
https://travis-ci.com/getsentry/getsentry/builds/118535665 getsentry tests running here. |
markstory
approved these changes
Jul 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ran out of arguments to pass to patterns. This should be more efficient anyway.
Also runs isort to sort imports consistently.