build(babel): Upgrade babel deps to 7.4.4#14359
Merged
Merged
Conversation
billyvg
force-pushed
the
build/babel/update-babel-deps
branch
from
August 12, 2019 23:17
68ae0e2 to
81e6309
Compare
Member
Member
Author
|
Tests are passing ¯_(ツ)_/¯ I've generally not had issues upgrading babel (at least non-major upgrades). |
dashed
approved these changes
Aug 13, 2019
dashed
left a comment
dashed
left a comment
Member
There was a problem hiding this comment.
I went thru the changelogs of babel from v7.0 to v7.5.
Looks good to me. 👍
Member
Author
|
I'll need to upgrade getsentry too |
Member
|
Oh true. 👍 |
dashed
requested changes
Aug 13, 2019
dashed
left a comment
dashed
left a comment
Member
There was a problem hiding this comment.
Holding back on my approval for a bit.
Member
|
Hmm. @billyvg im running into this issue for getsentry babel/babel#10264 |
Member
Author
|
@dashed ah yeah, they merged a fix but no release yet. |
Member
|
@billyvg i think we can relax babel to |
billyvg
force-pushed
the
build/babel/update-babel-deps
branch
from
August 15, 2019 20:52
81e6309 to
cd001e1
Compare
billyvg
changed the title
billyvg
force-pushed
the
build/babel/update-babel-deps
branch
from
August 21, 2019 21:25
cd001e1 to
1d3cfe8
Compare
billyvg
added a commit
that referenced
this pull request
Nov 12, 2019
No longer needed due to #14359 See the [release notes for babel@7.4.0](https://babeljs.io/blog/2019/03/19/7.4.0) for more information
billyvg
added a commit
that referenced
this pull request
Nov 13, 2019
No longer needed due to #14359 See the [release notes for babel@7.4.0](https://babeljs.io/blog/2019/03/19/7.4.0) for more information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.