Skip to content

chore(js): Replace all instances of objectToArray with Object.entries#14380

Merged
dashed merged 1 commit into
masterfrom
refactor/rm-rf-objectToArray
Aug 14, 2019
Merged

chore(js): Replace all instances of objectToArray with Object.entries#14380
dashed merged 1 commit into
masterfrom
refactor/rm-rf-objectToArray

Conversation

@dashed

@dashed dashed commented Aug 13, 2019

Copy link
Copy Markdown
Member

Follow up to #14199 (comment)

TODO

  • run tests on getsentry to see if travis is happy with this change

@dashed
dashed requested a review from a team August 13, 2019 21:22
@dashed dashed self-assigned this Aug 13, 2019

@evanpurkhiser evanpurkhiser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check getsentry as well?

@dashed

dashed commented Aug 13, 2019

Copy link
Copy Markdown
Member Author

@evanpurkhiser I haven't found any usages of objectToArray in getsentry.

I'm going to run the tests on getsentry with this commit to see if travis is happy.

@dashed
dashed force-pushed the refactor/rm-rf-objectToArray branch from e4f72be to 9ea20aa Compare August 13, 2019 23:47
@dashed
dashed merged commit 47b5b16 into master Aug 14, 2019
@dashed
dashed deleted the refactor/rm-rf-objectToArray branch August 14, 2019 00:35
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants