Skip to content

feat(ts): Add Client type to withAPI#14475

Merged
dashed merged 2 commits into
masterfrom
typescript-forward-slash-withAPI-with-Client-type
Aug 21, 2019
Merged

feat(ts): Add Client type to withAPI#14475
dashed merged 2 commits into
masterfrom
typescript-forward-slash-withAPI-with-Client-type

Conversation

@dashed

@dashed dashed commented Aug 21, 2019

Copy link
Copy Markdown
Member

☝️

@dashed
dashed requested a review from a team August 21, 2019 21:49
@dashed dashed self-assigned this Aug 21, 2019

@billyvg billyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you audit the other places where we need to update API types?

@dashed

dashed commented Aug 21, 2019

Copy link
Copy Markdown
Member Author

I will definitely audit other files for the API type in follow up PRs.

@dashed

dashed commented Aug 21, 2019

Copy link
Copy Markdown
Member Author

I updated src/sentry/static/sentry/app/views/settings/projectIncidentRules/ruleForm.tsx. Looks like it's the only other file that needs to be updated.

@billyvg

billyvg commented Aug 21, 2019

Copy link
Copy Markdown
Member

🤭

@dashed
dashed force-pushed the typescript-forward-slash-withAPI-with-Client-type branch from 693a7e7 to cc7df5f Compare August 21, 2019 22:05
@dashed
dashed merged commit 8f7ab69 into master Aug 21, 2019
@dashed
dashed deleted the typescript-forward-slash-withAPI-with-Client-type branch August 21, 2019 22:28
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants