Skip to content

ci(github): Add eslint action #17437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billyvg merged 3 commits into from
Mar 4, 2020
Merged

ci(github): Add eslint action #17437

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ceb679
ci(github): Add eslint action
billyvg Mar 3, 2020
db537a0
Update .github/workflows/eslint.yml
billyvg Mar 4, 2020
4d9c3b3
Update .github/workflows/eslint.yml
billyvg Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/eslint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: javascript
on: push
jobs:
build:
name: eslint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
node-version: '10.16.3'

- name: yarn install
run: yarn install --frozen-lockfile

- name: eslint
uses: getsentry/action-eslint@v1

@evanpurkhiser evanpurkhiser Mar 3, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have a custom action?

@billyvg billyvg Mar 3, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want tighter control over the actions, didn't want it from changing under us.

@dashed dashed Mar 3, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other orgs do this as well.

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
job-name: eslint