fix(apm): Adjust transaction name normalization#18968
Merged
Merged
Conversation
billyvg
approved these changes
May 21, 2020
Member
billyvg
left a comment
billyvg
left a comment
There was a problem hiding this comment.
Should we try to normalize some of the server rendered urls?
dashed
force-pushed
the
apm-adjust-transaction-normalization
branch
from
2bb53e0 to
10d9892
Compare
Member
Author
|
@billyvg We definitely should try to normalize server rendered urls; I'm going to think on this for a bit. I'll open another PR for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow up change to #18822
Make some adjustments to the transaction name normalization:
window.location.pathnamegetRouteStringFromRoutes()function returns either a blank string or/*, then fallback towindow.location.pathnamematch()function returns an error (it likely shouldn't), then fallback towindow.location.pathname