Revert "feat(feedback): add ff for ingest feedback topic"#67832
Closed
aliu39 wants to merge 1 commit into
Closed
Conversation
This reverts commit bb59152.
github-actions
Bot
added
the
Scope: Backend
Bundle ReportChanges will increase total bundle size by 552 bytes ⬆️
|
billyvg
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #67747
Found out from an ingest team member that this is not the right usecase for a feature flag.
store.rs, where we produce to kafka, is too late in the pipeline to have the project state as context. Which is where Relay keeps its feature flags. Instead we should use a regular option.