feat: Implement stub subcription endpoints#382
Conversation
tkaemming
left a comment
tkaemming
left a comment
There was a problem hiding this comment.
This looks generally fine to me, implementation-wise. We might end up moving the dataset parameter to the URL (e.g. /<dataset_name>/subscriptions), so going to hold off on approving until we've got that figured out. Feel free to test your stuff against this branch until then.
tkaemming
left a comment
tkaemming
left a comment
There was a problem hiding this comment.
Lets put these behind the if application.debug or application.testing check on L372 until we've actually implemented the bodies, but otherwise this is good.
We're punting on the URL thing until we have put more thought into how JOIN is going to work, so this will be fine. This might change in the future though — worst case we can route the request internally to the new URL for a while (as long as the request body is valid) until you have time to change your side when that happens.
Yeah it's nbd to change the urls I'm hitting as long as we have the old one available in the short term. |
d1b5996 to
8f07345
Compare
This introduces stubbed subscription endpoints, based on the spec we've discussed previously. Mostly for testing the integration from sentry.
8f07345 to
e7e71aa
Compare
## Bump sentry-conventions to 0.11.0 Updates `sentry-conventions` from 0.10.0 to [0.11.0](https://github.com/getsentry/sentry-conventions/releases/tag/0.11.0). ### Changes in 0.11.0 **New Features** - Add `session.id` attribute (#412) - Update several attributes to latest OTel representation (#418) - Add `db.operation.batch.size` (#407) - Add `app.vitals.start.prewarmed` attribute (#379) - Add and deprecate runtime context attributes (#383) - Add Android Runtime (ART) GC and memory attributes (#382) - Add `db.stored_procedure.name` and ensure span name attribute consistency (#398) - Add Cloudflare SDK attributes (#392) - Add missing GCP and FaaS attributes (#403) **Bug Fixes** - Set `pii: 'maybe'` on `faas` string attributes (#415) - Add missing Cloudflare visibility attributes (#408) **Internal** - Remove `sdks` field from attribute schema and definitions (#410)
3 participants
This introduces stubbed subscription endpoints, based on the spec we've discussed previously. Mostly for testing the integration from sentry.