fix: get_partitions_to_optimize should return a Sequence, not Iterable#405
Merged
Conversation
Similar to GH-403, this maintains the Python 2 behavior.
tkaemming
commented
Aug 9, 2019
|
|
||
| if before: | ||
| parts = filter(lambda p: (p[0] + timedelta(days=6 - p[0].weekday())) < before, parts) | ||
| parts = [p for p in parts if (p[0] + timedelta(days=6 - p[0].weekday())) < before] |
Contributor
Author
There was a problem hiding this comment.
Without this change, but preserving the annotations::
(snuba) ted@veneno % python -m mypy --follow-imports skip snuba/optimize.py
snuba/optimize.py:73: error: Incompatible types in assignment (expression has type "Iterator[Part]", variable has type "List[Part]")
|
|
||
| def decode_part_str(part_str): | ||
| class Part(NamedTuple): | ||
| date: datetime |
Contributor
Author
There was a problem hiding this comment.
This should probably be a date and not a datetime, but I haven't checked to see if that would break anything that expects it to be one and not the other.
mattrobenolt
approved these changes
Aug 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to GH-403, this maintains the Python 2 behavior.