fix(worker): keep worker health checks alive while idle in push mode#683
Merged
Conversation
george-sentry
approved these changes
Jun 8, 2026
george-sentry
left a comment
george-sentry
left a comment
Member
There was a problem hiding this comment.
We should do a quick test to make sure this doesn't significantly impact performance, but otherwise looks good!
Member
Author
Tested on 1 broker, 22 workers (32 processes/worker) and example task which takes 100ms, we are processsing 6.9k tasks/s on a theoretical limit of 7,040 tasks/s, so on this configuration there is no impact of the healthcheck thread on the workers. The healthcheck file now also updates even when there are no tasks / worker is idle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs STREAM-1056
Fixes push-mode worker health checks so low-throughput or idle workers continue touching the health check file.
Previously, push mode only emitted the health check from
update_task, which only runs after a task result is sent. Unlike pull mode, idle push workers had no predictable heartbeat and could be killed despite being healthy.