Skip to content

ref(producer): minor metrics improvements #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmckerry merged 1 commit into from
Jun 10, 2026
Merged

ref(producer): minor metrics improvements #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions clients/python/src/taskbroker_client/worker/workerchild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,16 +284,16 @@ def await_task_futures(task: ActivationWithPendingFutures) -> None:
)

def check_task_future_completion() -> None:
# Records how many activations with pending producer futures
# the worker child has.
metrics.gauge(
"taskworker.worker.activations_with_pending_futures",
len(pending_task_futures),
tags={
"processing_pool": processing_pool_name,
},
)
if len(pending_task_futures) > 0:
# Records how many activations with pending producer futures
# the worker child has. Only records when there are pending activations.
metrics.gauge(
"taskworker.worker.activations_with_pending_futures",
len(pending_task_futures),
tags={
"processing_pool": processing_pool_name,
},
)
for task in pending_task_futures.copy():
if all([f.done() for f in task.pending_futures]):
await_task_futures(task)
Expand All @@ -310,13 +310,13 @@ def check_task_future_completion() -> None:
break

try:
check_task_future_completion()
inflight = child_tasks.get(timeout=1.0)
except queue.Empty:
metrics.incr(
"taskworker.worker.child_task_queue_empty",
tags={"processing_pool": processing_pool_name},
)
check_task_future_completion()
continue

task_func = _get_known_task(inflight.activation)
Expand Down Expand Up @@ -474,8 +474,6 @@ def check_task_future_completion() -> None:
)
pending_task_futures.append(pending_task)

check_task_future_completion()

# Once we get the shutdown signal, drain any pending futures
for task in pending_task_futures.copy():
await_task_futures(task)
Expand Down
Loading