Skip to content

ref(workerchild): add produce future success/failure metrics #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmckerry merged 2 commits into from
Jun 11, 2026
Merged

ref(workerchild): add produce future success/failure metrics #697

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37b5c16
ref(workerchild): add produce future success/failure metrics
bmckerry Jun 11, 2026
4c8d26d
emit single metric
bmckerry Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions clients/python/src/taskbroker_client/worker/workerchild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,13 +267,22 @@ def await_task_futures(task: ActivationWithPendingFutures) -> None:
# We don't care about the actual result value,
# we just care if result() raises or not
[f.result(RESULT_TIMEOUT_SEC) for f in task.pending_futures]
produce_status = "success"
# If any pending producer futures failed, retry the task
except Exception:
task.status = TASK_ACTIVATION_STATUS_FAILURE
if task.task_func.retry:
retry_state = task.inflight.activation.retry_state
if not task.task_func.retry.max_attempts_reached(retry_state):
task.status = TASK_ACTIVATION_STATUS_RETRY
produce_status = "failure"
metrics.incr(
"taskworker.worker.produce.result",
tags={
"status": produce_status,
"processing_pool": processing_pool_name,
},
)
pending_task_futures.remove(task)
_task_execution_complete(
inflight=task.inflight,
Expand Down
Loading