Skip to content

fix: Allow configuring the push_task_timeout #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evanh merged 3 commits into from
Jun 15, 2026
+8 −4
Merged

fix: Allow configuring the push_task_timeout #698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b881c9
fix: Allow configuring the push_task_timeout
evanh Jun 11, 2026
fc940f5
move down
evanh Jun 11, 2026
9d3bb2d
merge
evanh Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clients/python/src/examples/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ def worker(
processing_pool_name="examples",
process_type="forkserver",
grpc_port=grpc_port,
push_task_timeout=5,
)
else:
worker = TaskWorker(
Expand Down
11 changes: 7 additions & 4 deletions clients/python/src/taskbroker_client/worker/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,9 @@ class WorkerServicer(taskbroker_pb2_grpc.WorkerServiceServicer):
gRPC servicer that receives task activations pushed from the broker
"""

def __init__(self, worker: TaskWorkerProcessingPool) -> None:
def __init__(self, worker: TaskWorkerProcessingPool, push_task_timeout: float = 5) -> None:
self.worker_pool = worker
self.push_task_timeout = push_task_timeout

def PushTask(
self,
Expand All @@ -81,8 +82,8 @@ def PushTask(
receive_timestamp=time.monotonic(),
)

# Push the task to the worker queue (wait at most 5 seconds)
if not self.worker_pool.push_task(inflight, timeout=5):
# Push the task to the worker queue (wait at most N seconds)
if not self.worker_pool.push_task(inflight, timeout=self.push_task_timeout):
self.worker_pool._metrics.incr(
"taskworker.worker.push_rpc",
tags={"result": "busy", "processing_pool": self.worker_pool._processing_pool_name},
Expand Down Expand Up @@ -139,6 +140,7 @@ def __init__(
health_check_file_path: str | None = None,
health_check_sec_per_touch: float = DEFAULT_WORKER_HEALTH_CHECK_SEC_PER_TOUCH,
grpc_port: int = 50052,
push_task_timeout: float = 5,
update_in_batches: bool = False,
) -> None:
app = import_app(app_module)
Expand Down Expand Up @@ -195,6 +197,7 @@ def __init__(

self._grpc_port = grpc_port
self._grpc_secrets = parse_rpc_secret_list(app.config["rpc_secret"])
self._push_task_timeout = push_task_timeout

def _create_client(
self,
Expand Down Expand Up @@ -343,7 +346,7 @@ def signal_handler(*args: Any) -> None:
)

taskbroker_pb2_grpc.add_WorkerServiceServicer_to_server(
WorkerServicer(self.worker_pool), server
WorkerServicer(self.worker_pool, self._push_task_timeout), server
)

# The health service is used by the K8s readiness check
Expand Down
Loading