Skip to content

ref(store): Validate database_name before CREATE DATABASE #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
untitaker merged 2 commits into from
Jun 19, 2026
+15 −0
Merged

ref(store): Validate database_name before CREATE DATABASE #721

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a04691
ref(store): Validate database_name before CREATE DATABASE
untitaker Jun 17, 2026
3a02a21
update comment
untitaker Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/store/adapters/postgres.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,21 @@ pub async fn migrate(config: &StoreConfig) -> Result<()> {
.await?;

if !row.0 {
// `CREATE DATABASE` does not accept bind parameters for the database
// name. but this is not a critical SQL injection as the database name is not untrusted
// user input. nevertheless, let's validate DB identifiers to prevent the worst.
if !config
.pg
.database_name
.chars()
.all(|c| matches!(c, 'a'..='z' | 'A'..='Z' | '0'..='9' | '_'))
{
return Err(anyhow!(
"invalid database_name {:?}: only ASCII alphanumerics and underscores are allowed",
&config.pg.database_name
));
}

println!("Creating database {}", &config.pg.database_name);
sqlx::query(format!("CREATE DATABASE {}", &config.pg.database_name).as_str())
.execute(&default_pool)
Expand Down
Loading