ref(config): (20) Improve Deprecated Mapping Macro#722
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
untitaker
approved these changes
Jun 18, 2026
untitaker
reviewed
Jun 18, 2026
| }; | ||
|
|
||
| if !user_provided(builder, "fetch.backoff") | ||
| if !provided("fetch.backoff") |
Member
There was a problem hiding this comment.
why is it not possible to use the macro for this case?
Member
Author
There was a problem hiding this comment.
Turned out to be possible with some changes - now those are done via macro as well.
untitaker
reviewed
Jun 18, 2026
untitaker
left a comment
untitaker
left a comment
Member
There was a problem hiding this comment.
do you plan to emit deprecation warnings for the old fields?
evanh
approved these changes
Jun 18, 2026
george-sentry
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear
Refs STREAM-843
Description
This is PART 20 of my configuration improvement effort. In this PR, I improve the deprecated mapping macro to simplify configuration deprecation and make it unnecessary to manually edit the string passed into
user_provided, which I have forgotten to do more than once on this journey.