Skip to content

ref(params): Remove JSON parameter encoding#723

Merged
untitaker merged 1 commit into
mainfrom
markusunterwaditzer/stream-1190-clean-up-taskbroker-params-encoding
Jun 19, 2026
Merged

ref(params): Remove JSON parameter encoding#723
untitaker merged 1 commit into
mainfrom
markusunterwaditzer/stream-1190-clean-up-taskbroker-params-encoding

Conversation

@untitaker

@untitaker untitaker commented Jun 19, 2026

Copy link
Copy Markdown
Member

ref STREAM-1190

  • Remove envvar for dual-write. We now always use msgpack. We've been dual-writing for quite a while everywhere.
  • Remove all JSON parsing, parameters is now unused
  • Remove orjson dependency since there is no perf-sensitive JSON parsing left

ref STREAM-1190

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@untitaker untitaker requested a review from a team as a code owner June 19, 2026 12:55
@linear-code

linear-code Bot commented Jun 19, 2026

Copy link
Copy Markdown

STREAM-1190

Comment on lines +96 to 99
if compression_type == CompressionType.ZSTD.value:
data = zstd.decompress(data)
return msgpack.unpackb(data, raw=False)

This comment was marked as spam.

@untitaker untitaker merged commit 7e9b2bf into main Jun 19, 2026
27 checks passed
@untitaker untitaker deleted the markusunterwaditzer/stream-1190-clean-up-taskbroker-params-encoding branch June 19, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants