Multi-sample phasing for ww-glimpse2 and ww-imputation#239
Merged
Conversation
emjbishop
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Refactors
glimpse2_phase_cramand theww-imputationpipeline to support joint multi-sample phasing, aligning with the Palantir/Broad GLIMPSE2 workflow pattern.ww-glimpse2moduleglimpse2_phase_cramnow acceptsArray[File] input_bamsandArray[File] input_bam_indicesinstead of a single file. The command block builds abam_list.txtfrom the array and passes it toGLIMPSE2_phasevia--bam-list, supporting both single-sample and multi-sample use cases.ww-imputationpipelineImputationSamplestruct and the outer per-sample scatter. All CRAMs are now passed into eachglimpse2_phase_cramcall for joint phasing across samples.truth_vcf/truth_vcf_indexinputs (instead of per-sample truth VCFs in the struct).output_prefix,concat_cpu_cores, andconcat_memory_gbparameters.Related Issue
glimpse2_phase_cram#240Testing
How did you test these changes?
What workflow engine did you use?
Did the tests pass?
Documentation
make docs-previewto check documentation rendering (if applicable)Additional Context
This is a breaking change to the
ww-imputationpipeline interface — theImputationSamplestruct is removed and replaced with flatArray[File]inputs. Theww-glimpse2module taskglimpse2_phase_cramalso has a breaking input signature change (File→Array[File]). Both modules are at prototype status so this is expected.