Conversation
emjbishop
approved these changes
Mar 10, 2026
Collaborator
emjbishop
left a comment
There was a problem hiding this comment.
Some minor suggestions
Co-authored-by: Emma Bishop <46635347+emjbishop@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Adds two new alignment modules to the WILDS WDL library:
ww-bowtie- Short-read alignment using Bowtie (v1.3.1), an ultrafast, memory-efficient aligner optimized for reads up to ~50 bp. Includesbowtie_buildandbowtie_aligntasks.ww-bowtie2- Sequence alignment using Bowtie 2 (v2.5.4), a fast and sensitive gapped-read aligner supporting variable-length reads. Includesbowtie2_buildandbowtie2_aligntasks.Both modules support paired-end and single-end alignment, produce sorted BAM + BAI output via samtools, and follow existing WILDS conventions (matching the
ww-bwamodule pattern).Testing
How did you test these changes?
Ran
testrun.wdlfor both modules using test data fromww-testdata(reference genome + FASTQ files). Both paired-end and single-end samples aligned successfully.What workflow engine did you use?
Sprocket (v0.18.0)
Did the tests pass?
Yes - both modules produce sorted BAM and BAI files for all test samples. Sprocket lint also passes clean.
Documentation
make docs-previewto check documentation rendering (if applicable)Additional Context
Both Docker images (
getwilds/bowtie:1.3.1andgetwilds/bowtie2:2.5.4) were updated to include samtools for BAM conversion/sorting within the alignment tasks.