Skip to content

Adding initial version of ww-fastp WILDS WDL module#278

Merged
tefirman merged 8 commits intomainfrom
add-fastp-module
Mar 23, 2026
Merged

Adding initial version of ww-fastp WILDS WDL module#278
tefirman merged 8 commits intomainfrom
add-fastp-module

Conversation

@tefirman
Copy link
Member

@tefirman tefirman commented Mar 17, 2026

Type of Change

  • New module

Description

Adds ww-fastp, a new WILDS WDL module wrapping fastp, an ultra-fast all-in-one FASTQ preprocessor. fastp performs quality filtering, adapter trimming, and comprehensive QC reporting in a single pass, making it a fast alternative to tools like Trimmomatic or Cutadapt.

The module includes two tasks:

  • fastp_paired — Paired-end FASTQ preprocessing with adapter auto-detection
  • fastp_single — Single-end FASTQ preprocessing

Also removes two unused linting rules (CommentWhitespace, TrailingComma) from sprocket.toml that were generating warnings.

Testing

How did you test these changes?
Ran make lint NAME=ww-fastp (sprocket, miniwdl, WOMtool all pass) and make run_sprocket NAME=ww-fastp using ww-testdata paired-end FASTQ files. Trimmed FASTQs and HTML/JSON QC reports were generated successfully.

What workflow engine did you use?
Sprocket v0.22.0

Did the tests pass?
Yes — linting clean across all three linters and testrun completed successfully.

Documentation

  • I updated the README (if applicable)
  • I added/updated parameter descriptions in the WDL (if applicable)
  • I ran make docs-preview to check documentation rendering (if applicable)

Additional Context

  • Uses Docker image getwilds/fastp:1.1.0 from Docker Hub
  • Test workflow uses relative imports for local development; these should be updated to GitHub raw URLs before merging

@tefirman tefirman marked this pull request as ready for review March 20, 2026 16:21
@tefirman tefirman requested a review from emjbishop as a code owner March 20, 2026 16:21
Copy link
Collaborator

@emjbishop emjbishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments

@tefirman tefirman merged commit 4c0538c into main Mar 23, 2026
12 checks passed
@tefirman tefirman deleted the add-fastp-module branch March 23, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants