Adding initial version of ww-fastp WILDS WDL module#278
Merged
Conversation
emjbishop
approved these changes
Mar 20, 2026
Collaborator
emjbishop
left a comment
There was a problem hiding this comment.
Just some minor comments
Co-authored-by: Emma Bishop <46635347+emjbishop@users.noreply.github.com>
…wdl-library into add-fastp-module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Adds
ww-fastp, a new WILDS WDL module wrapping fastp, an ultra-fast all-in-one FASTQ preprocessor. fastp performs quality filtering, adapter trimming, and comprehensive QC reporting in a single pass, making it a fast alternative to tools like Trimmomatic or Cutadapt.The module includes two tasks:
fastp_paired— Paired-end FASTQ preprocessing with adapter auto-detectionfastp_single— Single-end FASTQ preprocessingAlso removes two unused linting rules (
CommentWhitespace,TrailingComma) fromsprocket.tomlthat were generating warnings.Testing
How did you test these changes?
Ran
make lint NAME=ww-fastp(sprocket, miniwdl, WOMtool all pass) andmake run_sprocket NAME=ww-fastpusingww-testdatapaired-end FASTQ files. Trimmed FASTQs and HTML/JSON QC reports were generated successfully.What workflow engine did you use?
Sprocket v0.22.0
Did the tests pass?
Yes — linting clean across all three linters and testrun completed successfully.
Documentation
make docs-previewto check documentation rendering (if applicable)Additional Context
getwilds/fastp:1.1.0from Docker Hub