Skip to content

Enabling Cirro validation for a specific resource in Makefile#291

Merged
tefirman merged 1 commit intomainfrom
fix-cirro-makefile
Mar 24, 2026
Merged

Enabling Cirro validation for a specific resource in Makefile#291
tefirman merged 1 commit intomainfrom
fix-cirro-makefile

Conversation

@tefirman
Copy link
Member

Type of Change

  • Bug fix

Description

Updated make lint_cirro (and the underlying validate_cirro.py script) to respect the NAME parameter, consistent with all other lint targets. Previously, running make lint NAME=ww-toolname would validate .cirro configurations for all pipelines regardless of the NAME specified. Now:

  • make lint_cirro NAME=ww-pipeline-name validates only that pipeline's .cirro directory
  • make lint_cirro NAME=ww-module-name skips gracefully since modules don't have .cirro dirs
  • make lint_cirro (no NAME) continues to validate all pipelines as before

Testing

How did you test these changes?
Ran make lint_cirro NAME=ww-sra-salmon to confirm it validates only the specified pipeline, and make lint_cirro NAME=ww-star to confirm modules are skipped gracefully.

What workflow engine did you use?
N/A — linting/validation change only, no WDL execution involved.

Did the tests pass?
Yes

Documentation

  • I updated the README (if applicable)
  • I added/updated parameter descriptions in the WDL (if applicable)
  • I ran make docs-preview to check documentation rendering (if applicable)

Additional Context

The lint_cirro Makefile target now also depends on check_name for input validation, matching the pattern used by lint_sprocket, lint_miniwdl, and lint_womtool.

@tefirman tefirman requested a review from emjbishop as a code owner March 24, 2026 15:29
@tefirman tefirman merged commit 08be773 into main Mar 24, 2026
8 checks passed
@tefirman tefirman deleted the fix-cirro-makefile branch March 24, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants