Enabling Cirro validation for a specific resource in Makefile#291
Merged
Enabling Cirro validation for a specific resource in Makefile#291
Conversation
emjbishop
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Updated
make lint_cirro(and the underlyingvalidate_cirro.pyscript) to respect theNAMEparameter, consistent with all other lint targets. Previously, runningmake lint NAME=ww-toolnamewould validate.cirroconfigurations for all pipelines regardless of theNAMEspecified. Now:make lint_cirro NAME=ww-pipeline-namevalidates only that pipeline's.cirrodirectorymake lint_cirro NAME=ww-module-nameskips gracefully since modules don't have.cirrodirsmake lint_cirro(no NAME) continues to validate all pipelines as beforeTesting
How did you test these changes?
Ran
make lint_cirro NAME=ww-sra-salmonto confirm it validates only the specified pipeline, andmake lint_cirro NAME=ww-starto confirm modules are skipped gracefully.What workflow engine did you use?
N/A — linting/validation change only, no WDL execution involved.
Did the tests pass?
Yes
Documentation
I ranmake docs-previewto check documentation rendering (if applicable)Additional Context
The
lint_cirroMakefile target now also depends oncheck_namefor input validation, matching the pattern used bylint_sprocket,lint_miniwdl, andlint_womtool.