fix(threads): keep un-settled threads active after their PR merges (turbo) - #62
Merged
Conversation
Port of fork-main PR #61 onto turbo. Un-settling a thread whose PR had merged only lasted minutes: any session start or message cleared the keep-active pin back to neutral, and the merged-PR rule then re-settled the thread the moment the burst of work went quiet. - The explicit keep-active pin is now sticky: activity still wakes an explicitly SETTLED thread, but no longer spends the user's "not done" pin. Only an explicit settle clears it. (decider.ts, three sites) - Instant merged/closed-PR auto-settle applies only when the thread went quiet at or before the PR's completion; newer activity defers to the inactivity rule, fed by the PR's updatedAt now carried on the VCS status contract into web and mobile classification. Turbo specifics: the SidebarV2.tsx hunks are re-applied to Sidebar.tsx (upstream pingdotgg#5672 made v2 the default sidebar); new seam settled-lifecycle-sticky-pin registered in .t3-turbo/customizations.json (verify passes: 26 seams, 172 checks); changelog entry added. Upstream context: pingdotgg#5575, pingdotgg#5643. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
github-actions
Bot
added
size:L
vouch:trusted
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
…est test Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Formatting was broken at the tip of turbo (8901313) and fails the Check job for every PR; formatted here to unblock. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #61 onto
turbo. See that PR for the full root-cause writeup and upstream context (pingdotgg#5575, pingdotgg#5643).Turbo-specific parts:
SidebarV2.tsxhunks are re-applied toSidebar.tsx— upstream feat: sidebar v2 is now the default sidebar pingdotgg/t3code#5672 (in turbo's newer ingest) made sidebar v2 the default and renamed the file. Everything else cherry-picked cleanly.settled-lifecycle-sticky-pinregistered in.t3-turbo/customizations.json;turbo:customizations:verifypasses (26 seams, 172 file checks). Marked as an upstream candidate: drop the seam if upstream merges an equivalent.Verified on this branch: server orchestration (27), client-runtime threadSettled (180), web logic suites (154), mobile thread lists (61) all green; typecheck clean across contracts, client-runtime, server, web, mobile; no turbo-only
effectiveSettledcallers needed wiring.🤖 Generated with Claude Code