Skip to content

Streaming conversion with no torch#176

Closed
diimdeep wants to merge 6 commits into
ggml-org:masterfrom
diimdeep:streaming
Closed

Streaming conversion with no torch#176
diimdeep wants to merge 6 commits into
ggml-org:masterfrom
diimdeep:streaming

Conversation

@diimdeep
Copy link
Copy Markdown

Drop torch, do not load whole file into memory, process files in parallel and use separate threads for r/w

Comment thread convert-pth-to-ggml.py
q = queue.Queue(maxsize=2)

def writer():
while True:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while True? Does this function ever return? I don't know if the function exists but maybe something like while !q.atEnd()

Please correct me if I'm wrong. I haven't worked with Python since a year or so.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@gjmulder gjmulder added enhancement New feature or request performance Speed related topics labels Mar 15, 2023
@sw
Copy link
Copy Markdown
Contributor

sw commented Mar 19, 2023

The python dependencies in .devops/full.Dockerfile should also be updated, will conflict with my PR #293.

@ggerganov
Copy link
Copy Markdown
Member

This looks like a very useful addition. Lets give it a priority and merge after resolving the conflicts

@tim-gromeyer
Copy link
Copy Markdown

@ggerganov Any update on this? Because I really do not want to install pytorch on my system (because of memory).

@Green-Sky Green-Sky added the high priority Very important issue label Mar 26, 2023
@sw sw mentioned this pull request Mar 27, 2023
16 tasks
@ggerganov
Copy link
Copy Markdown
Member

This is probably too outdated so closing for now

@ggerganov ggerganov closed this Mar 30, 2023
phuongncn pushed a commit to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4 that referenced this pull request Apr 28, 2026
Co-authored-by: Stanisław Szymczyk <sszymczy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request high priority Very important issue performance Speed related topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants