Skip to content

model: fix llama arch implementation - #17665

Merged
ngxson merged 1 commit into
ggml-org:masterfrom
giladgd:fixLlamaArch
Dec 1, 2025
Merged

model: fix llama arch implementation#17665
ngxson merged 1 commit into
ggml-org:masterfrom
giladgd:fixLlamaArch

Conversation

@giladgd

@giladgd giladgd commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@giladgd
giladgd requested a review from CISC as a code owner December 1, 2025 20:14
@giladgd

giladgd commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

@ngxson The llama arch seems to be broken since #17644, I noticed it since it failed tests that I run on some llama models.
I think you meant to copy the ml.get_key(LLM_KV_ATTENTION_LAYERNORM_RMS_EPS, hparams.f_norm_rms_eps); line instead of moving it.

ngxson
ngxson approved these changes Dec 1, 2025
View reviewed changes

@ngxson ngxson left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm yeah that was a mistake, thanks for the fix

@ngxson
ngxson merged commit 00c361f into ggml-org:master Dec 1, 2025
60 of 65 checks passed
@giladgd
giladgd deleted the fixLlamaArch branch December 1, 2025 20:26
@gabe-l-hart gabe-l-hart mentioned this pull request Dec 10, 2025
Merged
Anico2 added a commit to Anico2/llama.cpp that referenced this pull request Jan 15, 2026
@Anico2
fix: llama arch implementation (ggml-org#17665)
20e5ea2
blime4 referenced this pull request in blime4/llama.cpp Feb 5, 2026
@giladgd shaobo.xie
fix: llama arch implementation (#17665)
ed9e4d7
Seunghhon pushed a commit to Seunghhon/llama.cpp that referenced this pull request Apr 26, 2026
@giladgd
fix: llama arch implementation (ggml-org#17665)
80f7c17
ljubomirj pushed a commit to ljubomirj/llama.cpp that referenced this pull request May 6, 2026
@giladgd
fix: llama arch implementation (ggml-org#17665)
71a1d92
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
@giladgd
fix: llama arch implementation (ggml-org#17665)
d0f5fab
my-other-github-account pushed a commit to my-other-github-account/llama.cpp that referenced this pull request May 15, 2026
@giladgd
fix: llama arch implementation (ggml-org#17665)
287f1e7
phibya pushed a commit to ziee-ai/llama.cpp that referenced this pull request May 29, 2026
@giladgd
fix: llama arch implementation (ggml-org#17665)
62a6da7
fewtarius pushed a commit to fewtarius/CachyLLama that referenced this pull request May 30, 2026
@giladgd
fix: llama arch implementation (ggml-org#17665)
4c51c17
fukuro-kun pushed a commit to fukuro-kun/fukuro-llama-cpp-turboquant that referenced this pull request Jul 5, 2026
@giladgd
fix: llama arch implementation (ggml-org#17665)
dca0fbe
MrLordCat referenced this pull request in MrLordCat/llama.cpp-with-GUI Jul 16, 2026
@giladgd
fix: llama arch implementation (#17665)
4782df7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngxson ngxson ngxson approved these changes
@CISC CISC Awaiting requested review from CISC CISC is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giladgd @ngxson