model: don't crash on unsupported architecture - #22742
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
@ggml-bot I'm not a new contributor |
|
@giladgd the bot looks at the last 90 days for this check for performance reasons. Sorry about the noise |
You lost me? |
|
@CISC In the past, when trying to load a model with an unsupported architecture (for example, loading an mmproj using This PR fix that, so that trying to load an unsupported model will just fail (like before) and won’t crash the process. |
|
Ah, I see, because |
Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
* model: don't crash on unsupported architecture * Update src/llama-model.cpp Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
* model: don't crash on unsupported architecture * Update src/llama-model.cpp Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
* model: don't crash on unsupported architecture * Update src/llama-model.cpp Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
* model: don't crash on unsupported architecture * Update src/llama-model.cpp Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
* model: don't crash on unsupported architecture * Update src/llama-model.cpp Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com>
Overview
Before #22004, when trying to load a model with an unsupported architecture using
llama_model_load_from_fileit used to just fail silently and returnnullptrinstead of crashing.This PR restores the old behavior.
Requirements