model : fix model type check for granite/llama3 and deepseek2/glm4.7 lite - #22870
Merged
Conversation
CISC
changed the title
CISC
changed the title
JohannesGaessler
approved these changes
May 9, 2026
JohannesGaessler
left a comment
JohannesGaessler
left a comment
Contributor
There was a problem hiding this comment.
I can confirm that the model type is now being set correctly.
CISC
added
the
merge ready
taronaeo
approved these changes
May 10, 2026
meh
pushed a commit
to meh/llama.cpp
that referenced
this pull request
May 10, 2026
baramofme
pushed a commit
to baramofme/llama-cpp-turboquant
that referenced
this pull request
May 23, 2026
winstonma
pushed a commit
to winstonma/llama.cpp
that referenced
this pull request
May 27, 2026
fewtarius
pushed a commit
to fewtarius/CachyLLama
that referenced
this pull request
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
cont #22004
Fixes #22004 (comment)
Additional information
The checks used uninitialized
n_vocabinstead of fetching from metadata as was done before refactor.This also broke
liteclassification and inference of some (Kanana-2?) DeepSeek2 Lite and GLM 4.7 Lite models.Requirements