vulkan: Read nodes_per_submit from GGML_VK_NODES_PER_SUBMIT env - #24240
vulkan: Read nodes_per_submit from GGML_VK_NODES_PER_SUBMIT env#24240konradmb wants to merge 1 commit into
nodes_per_submit from GGML_VK_NODES_PER_SUBMIT env#24240Conversation
github-actions
Bot
added
Vulkan
|
Hi @konradmb, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
c01c19c to
2a79a51
Compare
| static int nodes_per_submit = []() { | ||
| const char* env = getenv("GGML_VK_NODES_PER_SUBMIT"); | ||
| return env ? atoi(env) : 100; | ||
| }(); |
There was a problem hiding this comment.
This would have to become a vk_device parameter, you cannot read the environment variable in the graph_compute function.
There was a problem hiding this comment.
Ok, I'll try. Do you have any examples of how similar features are implemented?
Should I add a new int to vk_device_struct and set it somewhere else from env var?
There was a problem hiding this comment.
Yes, exactly. Look at other flags/values there, like async_use_transfer_queue.
|
@wbruna Sure, great! Closing this one. |
3 participants
Overview
Allow setting a custom
nodes_per_submitvalue.Additional information
Workaround for #21724
Requirements