server: use status code 403 for disabled features - #24970
Merged
Conversation
ngxson
changed the title
ServeurpersoCom
approved these changes
Jun 24, 2026
taronaeo
approved these changes
Jun 24, 2026
Member
|
Request to add a condition to change it to code 418 on any date with month = 4, day = 1 ;) |
Collaborator
Author
|
that may requires RFC 1149 to work correctly |
ngxson
commented
Jun 25, 2026
Comment on lines
+395
to
402
| // 403 from /tools means the server was started without --tools | ||
| // TODO: check status code instead of relying on message | ||
| if (errorMessage.includes('this feature is disabled')) { | ||
| this._toolsEndpointUnreachable = true; | ||
| console.info('[ToolsStore] Built-in tools are disabled on the server'); | ||
| } else { | ||
| console.error('[ToolsStore] Failed to fetch built-in tools:', err); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
cc @allozaur maybe better to expose the status code in Error object, but I'll let you to improve it if needed
papamoose
pushed a commit
to papamoose/llama.cpp
that referenced
this pull request
Jun 27, 2026
* server: use status code 403 for disabled features * cont * fix test case
adrianhoehne
pushed a commit
to adrianhoehne/llama.cpp
that referenced
this pull request
Jul 5, 2026
* server: use status code 403 for disabled features * cont * fix test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Return 403 +
feature_disablederror type for disabled feature (CORS proxy, tools)close #24894
Requirements