chat: harden caps check - #24973
Merged
Merged
Conversation
Contributor
|
This looks fine to me, I can't seem to reproduce serial only tool call behavior I saw in #24181 |
ngxson
approved these changes
Jun 24, 2026
Member
Author
|
@ggml-org/maintainers need a second approval please. |
Contributor
|
Confused, does Step 3.7 provide two templates in its GGUF? I thought template variants are now mostly unused. For example, https://huggingface.co/bartowski/c4ai-command-r7b-12-2024-GGUF does have a tool use template. https://huggingface.co/unsloth/Step-3.7-Flash-GGUF does not. I think change is harmless and technically valid but I don't believe it does anything meaningful. I haven't seen template variants used in any modern models. |
aldehir
approved these changes
Jun 25, 2026
papamoose
pushed a commit
to papamoose/llama.cpp
that referenced
this pull request
Jun 27, 2026
adrianhoehne
pushed a commit
to adrianhoehne/llama.cpp
that referenced
this pull request
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
A weird edge case was reported by @tarruda in #24181 that the caps detection doesn't pass through corectly.
Additional information
Hardened the test so that it takes the more expressive template instead of the default one, since eg. some agents will occasionally run a non-tool-aware query (such as generating a title) that will trigger the non-tools path.
Requirements