ci: abort if build requirements are missing - #26368
Merged
Merged
Conversation
1. Abort CI if build requirements are missing. 2. Add check to make sure Git LFS has been configured. 3. Add trailing newlines to log messages.
nikwen
force-pushed
the
git-lfs-error-message
branch
from
August 6, 2026 09:48
c493dcf to
5615eec
Compare
Collaborator
Author
|
@taronaeo Would you have time to take a look at another CI PR? Thank you so much in advance! :) |
taronaeo
approved these changes
Aug 6, 2026
Comment on lines
+655
to
658
| if ! git config --get filter.lfs.clean &> /dev/null; then | ||
| gg_printf 'git-lfs not initialized, please run `git lfs install`\n' | ||
| exit 1 | ||
| fi |
Member
There was a problem hiding this comment.
Thanks! This is easily missed when setting up CI :)
Collaborator
Author
There was a problem hiding this comment.
I missed it locally. Thanks for your review! :)
miltos22
pushed a commit
to miltos22/llama.cpp-wackMall-merge-request
that referenced
this pull request
Aug 10, 2026
1. Abort CI if build requirements are missing. 2. Add check to make sure Git LFS has been configured. 3. Add trailing newlines to log messages.
satindergrewal
pushed a commit
to satindergrewal/llama.cpp
that referenced
this pull request
Aug 11, 2026
1. Abort CI if build requirements are missing. 2. Add check to make sure Git LFS has been configured. 3. Add trailing newlines to log messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Running CI locally was failing for me and it wasn't obvious from the error message why.
This PR makes it easier for contributors to figure out what's going on:
Additional information
Error message that I got
Turns out you need to have Git LFS installed and configured, which I didn't have.
The existing check for this didn't abort the run. Thus, I missed its short message in a huge wall of text.
Requirements