ci: fix pre-built binaries no longer working on macOS 15 and below - #26375
Conversation
|
@taronaeo I see that you've reviewed many CI PRs. Would you be so kind as to review this PR? Thank you! :) |
|
Can you provide a link to successful runs from your forked repository? I don't have a macOS version that low. |
|
/bot review |
Automated code reviewI reviewed this CI-only change. It's small, well-scoped, and consistent with the existing pattern. SummaryThe PR sets
The fix is correct and minimal. FindingsBlocking: none. Will slow the review: none. The change is self-contained, single-purpose, and reuses the existing convention rather than introducing new machinery. Nits: (point 1) In (point 2) The chosen target This review was generated automatically by pi coding agent using |
|
@taronaeo Thanks for taking a look! I also don't have a macOS version that low, but:
Thus, I'm confident in the fix.
What exactly would you like to get a link to? |
We usually ask for a link to a successful CI run from the author's fork to see that its actually working before we review. But no worries, it's evident to me that the changes are OK with your explanation :) |
Ah, understood! I'll keep that in mind for the future. Thank you for your review! |
CISC
left a comment
There was a problem hiding this comment.
As suggested by the bot review, add it to the disabled KleidiAI build as well.
Done. Thanks for the review! If one of you could kick off CI again, that would be awesome. |
…gml-org#26375) * ci: fix pre-built binaries no longer working on macOS 15 and below * ci: add macOS deployment target to disabled KleidiAI build
…gml-org#26375) * ci: fix pre-built binaries no longer working on macOS 15 and below * ci: add macOS deployment target to disabled KleidiAI build
…gml-org#26375) * ci: fix pre-built binaries no longer working on macOS 15 and below * ci: add macOS deployment target to disabled KleidiAI build
Overview
Fixes #26370
Fixes the pre-built ARM64 binaries no longer working on macOS 15 and below.
Additional information
Before this PR, the ARM64 macOS job did not set
CMAKE_OSX_DEPLOYMENT_TARGET. Thus, the runner's SDK default was used (26.0).Details
#26061 introduced these lines:
llama.cpp/vendor/sheredom/subprocess.h
Lines 1208 to 1210 in 876a432
This symbol does not exist before macOS 26. But
MAC_OS_X_VERSION_MIN_REQUIREDwas inferred as macOS 26. Thus, the builds no longer ran on macOS 15 and below.This PR sets the ARM64 macOS deployment target to the same value that is being used for the x64 macOS deployment target.
To make sure we test this build properly, I've adjusted the CI build arguments accordingly.
Requirements