tests: Mitigate test-model-resolution crashing on MSYS2 UCRT64 environment - #26555
Merged
Merged
Conversation
ServeurpersoCom
approved these changes
Aug 4, 2026
ServeurpersoCom
left a comment
ServeurpersoCom
left a comment
Contributor
There was a problem hiding this comment.
LGTM, we just need to confirm there is no regression on the CI. Build tested on Linux and Windows.
Contributor
Author
|
Hi @ServeurpersoCom are you able to add the "merge ready" tag to this PR? I'd rather fix the CI crashing soon so we don't miss too many changes. |
ServeurpersoCom
added
the
merge ready
ngxson
approved these changes
Aug 7, 2026
allozaur
approved these changes
Aug 7, 2026
miltos22
pushed a commit
to miltos22/llama.cpp-wackMall-merge-request
that referenced
this pull request
Aug 10, 2026
satindergrewal
pushed a commit
to satindergrewal/llama.cpp
that referenced
this pull request
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #26552. Mitigates crashing issue occurring in Windows MSYS2 UCRT64 environment. While I haven't fully checked, the original code maybe undefined behavior since we're initializing
&files(reference to a vector) with a temporary vector where its lifetime is not guaranteed.Additional information
Requirements