Attempted fix for main example getting stuck when -n -2 and --interactive#2767
Merged
KerfuffleV2 merged 2 commits intoAug 24, 2023
Merged
Conversation
ghost
mentioned this pull request
ghost
reviewed
Aug 24, 2023
slaren
approved these changes
Aug 24, 2023
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
…-org#2767) * Fix for main example getting stuck when -n -2 and --interactive * Add a comment so future generations may suffer less.
phuongncn
pushed a commit
to phuongncn/llama.cpp-gx10-dgx-sparks-deepseekv4
that referenced
this pull request
Apr 28, 2026
…-org#2767) * Fix for main example getting stuck when -n -2 and --interactive * Add a comment so future generations may suffer less.
ljubomirj
pushed a commit
to ljubomirj/llama.cpp
that referenced
this pull request
May 6, 2026
…-org#2767) * Fix for main example getting stuck when -n -2 and --interactive * Add a comment so future generations may suffer less.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure this is the correct fix (seems fairly likely though since setting
n_remainto-2looks pretty weird).Closes #2754