server: do not remove whitespace at the start of a completion chunk (reapply to new UI)#7830
Merged
mofosyne merged 1 commit intoggml-org:masterfrom Jun 9, 2024
Conversation
mofosyne
approved these changes
Jun 9, 2024
Collaborator
|
@mgroeber9110 is the CI issue related to your code or master branch? |
Contributor
Author
|
Looking at the error log, this appears to be related to the test environment for Windows: This looks unrelated to my change. |
Collaborator
|
Okay, then it's most likely due the issue a few weeks ago. Going to merge in directly anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges the change in #7524 to the new UI to keep the two implementations in sync.
Original description:
When looking at this change again, I noticed that the code is also used in Chat mode, but in this case HTML rendering removes the whitespace at the start of a conversation turn (after "assistant"), and the conversation transcript looks to be okay afterwards.