Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to create fictitious consumption readings when receiving a totalized meter reading with new tariff codes. The main purpose is to handle cases where the ERP needs to generate fake readings because certain period-specific readings are not provided in the incoming data.
Key changes:
- Extracted fake lecture creation logic into a dedicated method
get_fake_lectures() - Added support for creating fake period readings (P1, P2, etc.) when receiving AE totalizer readings with new tariff codes
- Added helper methods to detect AE totalizer readings and generate appropriate fake period readings
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c74abfc to
d60581d
Compare
eberloso
approved these changes
Nov 4, 2025
eberloso
approved these changes
Nov 4, 2025
This was referenced Nov 4, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Objetivos
90yA0).⚙️ Comportamiento Anterior
🔹 Caso Lecturas PRE TD
3008.🔹 Caso Lecturas TD
3008.🆕 Comportamiento Nuevo
🔹 Caso Lecturas PRE TD
🔹 Caso Lecturas TD
Cuando la factura tiene el consumo repartido en varios periodos y el F1 incluye lecturas TD, se siguen estos pasos:
Obtener lecturas por fecha
Analizar cada fecha
90oA0).Crear lecturas a partir del totalizador
📝 Notas