Avoid repeat Content-Transfer-Encoding#55
Closed
destanyol wants to merge 5 commits intogisce:masterfrom
Closed
Conversation
…e64_mimetype_repeated
Contributor
Author
|
Closed, new PR in #65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that the shared inbox e-mail client we are using has trouble with some repeated headers of the attachment.
In particular it has trouble with the "Content-Transfer-Encoding" header. Qreu sends it two times like this:
By default when you create the attachment as a
MIMEApplicationthe Content-Transfer-Encoding header is added by default and also by default is base64, so theContent-Transfer-Encodingdoesn't have to be added manually afterwards.But, because "Explicit is better than implicit" in this Pull Request I have hardcoded the _encoder to base64 so the change is more clear for the reviewer.
The result with the new changes are: