Skip to content

rename: remove git-credential-manager-core symlinks - #1327

Merged
ldennington merged 1 commit into
git-ecosystem:mainfrom
ldennington:remove-symlinks
Jul 17, 2023
Merged

rename: remove git-credential-manager-core symlinks#1327
ldennington merged 1 commit into
git-ecosystem:mainfrom
ldennington:remove-symlinks

Conversation

@ldennington

@ldennington ldennington commented Jul 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Since 2 versions of Git have released since the rename of the executable from git-credential-manager-core to git-credential-manager, remove the associated symlinks and warnings, (as outlined in docs/rename.md).

@ldennington
ldennington requested a review from mjcheetham July 11, 2023 21:44
@ldennington ldennington self-assigned this Jul 11, 2023
mjcheetham
mjcheetham requested changes Jul 11, 2023
View reviewed changes

@mjcheetham mjcheetham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think we can remove some more in Program.cs too.
Also, I wonder if we should update the rename doc to say that the old symlink/name was retired in 2.3.x.

Comment thread src/shared/Git-Credential-Manager/Program.cs Outdated
@ldennington

ldennington commented Jul 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I wonder if we should update the rename doc to say that the old symlink/name was retired in 2.3.x.

@mjcheetham - I don't want to be in the same situation we were before where we have a placeholder hanging around. Instead, how about I leave the issue open (I've removed the Fixes from the PR description) until this is released with an outstanding item to update rename.md with the correct version?

@mjcheetham

mjcheetham commented Jul 11, 2023

Copy link
Copy Markdown
Contributor

I wonder if we should update the rename doc to say that the old symlink/name was retired in 2.3.x.

@mjcheetham - I don't want to be in the same situation we were before where we have a placeholder hanging around. Instead, how about I leave the issue open (I've removed the Fixes from the PR description) until this is released with an outstanding item to update rename.md with the correct version?

Sure, that works too!

@ldennington Lessley Dennington
rename: remove git-credential-manager-core symlinks
88cae6b 
Since 2 versions of Git have released since the rename of the executable
from git-credential-manager-core to git-credential-manager, remove the
associated symlinks and warnings, (as outlined in docs/rename.md).
@ldennington
ldennington merged commit 2334200 into git-ecosystem:main Jul 17, 2023
@ldennington ldennington mentioned this pull request Aug 1, 2023
Merged
ldennington added a commit that referenced this pull request Aug 1, 2023
@ldennington
GCM release 2.3.0 (#1361)
58e34e3 
**Changes since 2.2.2:**

- Fix a GCM/Git Trace2 file locking issue
  - Issue: #1323 
  - PR: #1340
- Remove symlinks to `git-credential-manager-core` exe
  - Issue: #1322
  - PR: #1327 
- Add fallback http uri to `diagnose` command
  - Issue: #1215
  - PR: #1339
- Workaround MSAL tenant issue with silent auth
  - Issue: #1297
  - PR: #1321
@ldennington
ldennington deleted the remove-symlinks branch August 19, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcheetham mjcheetham mjcheetham approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@ldennington ldennington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ldennington @mjcheetham