Fix a few issues with TRACE2 output - #1909
Merged
Merged
Conversation
There are a few bugs in the way we read a pipe or socket name for the TRACE2 event target. We do not correctly trim the \\.\pipe\ prefix on Windows, if present. On Unix we do not correctly strip the af_unix: prefix correctly if a socket file path contains a ':'. Let's fix this! Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
In a message that is formatted/parameterised, we incorrectly use the field name of 'format' rather than 'fmt'. Fix this. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dscho
approved these changes
Sep 24, 2025
dscho
left a comment
dscho
left a comment
Contributor
There was a problem hiding this comment.
Still looks good to me, @mjcheetham!
This comment was marked as off-topic.
This comment was marked as off-topic.
Merged
mjcheetham
added a commit
that referenced
this pull request
Jan 14, 2026
**Changes:** - Documentation updates & fixes - #1713 - #1722 - #1884 - #2123 - #2154 - Fix Generic provider refresh token refresh logic (#1838) - Version bump to 2.7.0 (#2177) - CODEOWNERS (#2053) - Allow unsafe remotes via config (#1721) - Drop no longer needed GitLab OAuth params (#1538) - No-op credential storage option (#1740) - Fixes to CI & build - #1746 - #1747 - #1752 - #2104 - #2217 - Use Azure Pipelines for official builds - #2054 - #2176 - Fix TRACE2 logging (#1909) - Linux ARM and ARM64 support - #1633 - #2232 - Windows ARM64 and x64 support (#2230) - Linux install-from-source bug fixes - #1757 - #2049 - #2052 - Support Oracle Linux vis install-from-source (#2212) - macOS enterprise defaults (#1811) - Actions dependency updates - #1725 - #1751 - #1750 - #1760 - #1799 - #2022 - #2048 - #1989 - #2011 - #2029 - #2051 - #2050 - #2070 - #2080 - #2089 - #2088 - #2092 - #2189 - #2193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a few problems with the TRACE2 support when writing to a pipe/socket. The handling of the
trace2.eventTargetsetting to get the correct pipe name/socket file path was incorrect resulting in names like "pipe\foobar" when given "//./pipe/foobar" on Windows, when it should be "foobar".Also the event field name 'format' is incorrect; it should be 'fmt'.