Skip to content

mingw-w64-git-credential-manager: update to 2.4.1 - #533

Merged
dscho merged 1 commit into
mainfrom
mingw-w64-git-credential-manager-2.4.1
Nov 2, 2023
Merged

mingw-w64-git-credential-manager: update to 2.4.1#533
dscho merged 1 commit into
mainfrom
mingw-w64-git-credential-manager-2.4.1

Conversation

@gitforwindowshelper

Copy link
Copy Markdown

Signed-off-by: Matthias Aßhauer <mha1993@live.de>
@rimrul
rimrul marked this pull request as ready for review November 2, 2023 12:07
@rimrul

rimrul commented Nov 2, 2023

Copy link
Copy Markdown
Member

/deploy

The workflow run was started.

@dscho

dscho commented Nov 2, 2023

Copy link
Copy Markdown
Member

@rimrul This symptom is the same as of this failure:

BUG: wrapper.c:680: your snprintf is broken

I am in the process of investigating a working-around; My guess is that mingw-w64-x86_64-gettext changed how it handles libintl_vsnprintf(), and that the newer version returns values that Git's core contributors consider "bogus".

@dscho

dscho commented Nov 2, 2023

Copy link
Copy Markdown
Member

My guess is that mingw-w64-x86_64-gettext changed how it handles libintl_vsnprintf()

Indeed. Fuller analysis: msys2/MINGW-packages#18983 (comment).

I think we'll need to pin mingw-w64-gettext to known-good versions for now.

@dscho

dscho commented Nov 2, 2023

Copy link
Copy Markdown
Member

/add relnote

The workflow run was started

@dscho
dscho merged commit 188236a into main Nov 2, 2023
@dscho
dscho deleted the mingw-w64-git-credential-manager-2.4.1 branch November 2, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[New git-credential-manager version] GCM 2.4.1

2 participants