git update-git-for-windows downgrades git from 2.19.2 to 2.19.1

[createdbyjurand]

• I was not able to find an open or closed issue matching what I'm seeing

Setup

• Which version of Git for Windows are you using? Is it 32-bit or 64-bit?
  64-bit

$ git --version --build-options

git version 2.19.2.windows.1
cpu: x86_64
built from commit: 26dcaa1b6b5fd862db3ec40983e33ff3432f1166
sizeof-long: 4
sizeof-size_t: 8

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

$ cmd.exe /c ver

Microsoft Windows [Version 10.0.16299.785]

• What options did you set as part of the installation? Or did you choose the
  defaults?

# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

Editor Option: VisualStudioCode
Custom Editor Path: 
Path Option: Cmd
SSH Option: OpenSSH
CURL Option: WinSSL
CRLF Option: CRLFAlways
Bash Terminal Option: ConHost
Performance Tweaks FSCache: Enabled
Use Credential Manager: Enabled
Enable Symlinks: Disabled

• Any other interesting things about your environment that might be related
  to the issue you're seeing?

No

Details

• Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

PowerShell

• What commands did you run to trigger this issue? If you can provide a
  Minimal, Complete, and Verifiable example
  this will help us understand the issue.

git update-git-for-windows

• What did you expect to occur after running these commands?

Nothing or new version of Git

• What actually happened instead?

Downgrade to 2.19.1

• If the problem was occurring with a specific repository, can you provide the
  URL to that repository to help us with testing?

** insert URL here **

[jumoog]

download the intaller manually helps

[Harmon758]

I also received a prompt to downgrade to 2.19.1 when I have 2.19.2 installed:

This is due to https://api.github.com/repos/git-for-windows/git/releases/latest showing 2.19.1 as the lastest release, as can also be seen on https://github.com/git-for-windows/git/releases:

I believe this is because 2.19.2 was a tag pushed to the repository without a title, description, or assets and without having a release formally created.
This should be easily resolved by publishing a new release through https://github.com/git-for-windows/git/releases/new using the existing tag.

[coldino]

I received an automatic update prompt today, which tries to downgrade from the previously automatically-installed 2.19.2 to 2.19.1:

On checking the GitHub releases I see 2.19.2 has been marked pre-release due to breaking bugs, but this information is not communicated to users at all during the automatic update process. Without scanning through the issues, I don't know whether allow the automatic downgrade - or if something nefarious is going on.

[Harmon758]

@coldino 2.19.2 is released and is the default download now.
You're referring to a pre-release tag prior to the 2.19.2 tag.
Although, I believe this was the 2.19.2 release tag before the edit.
I believe the reason this is an issue is because this pre-release tag was previously the latest release, before it was edited to be pre-release, so those who updated to it before that edit are now getting the prompt to downgrade.

[dscho]

https://github.com/git-for-windows/git/releases/tag/v2.19.2.windows.1 is available, still, but was demoted to "pre-release" status because it has two serious bugs. See also this part of the description on that very page:

EDIT November 26th 2018: marking as pre-release because of two major breakages in this version; Git for Windows v2.20.0 (which is slated for December 3rd) will fix them both.]

In other words, there will not be any v2.19.2(2) this close to v2.20.0.

[coldino]

There is certainly a discrepancy here.

• https://git-scm.com/download/win gives users 2.19.2.
• The auto-update system will try to downgrade users to 2.19.1.

If 2.19.2 has been demoted from being the latest then it should not be the default version offered for download.

This was not a clean way to handle reverting a release.

[dscho]

* https://git-scm.com/download/win gives users 2.19.2.

Bummer. It should have updated by now.

This was not a clean way to handle reverting a release.

Sorry, there was no good option. I already integrated an upgrade from OpenSSL v1.0.2p to v1.1.1a which I deemed possibly incurring new bugs, and therefore could not simply upgrade Git for Windows to v2.19.2(2).

Also, to be quite honest, it is quite a lot of work y'all let me do here on my own.

[JTBrinkmann]

I can confirm that git-scm.com still offers 2.19.2 as download. See git/git-scm.com#1278 and #1955

This was not a clean way to handle reverting a release.

If this is deemed worth the efford, maybe a routine could be found that also (automatically) addresses git-scm.com issue. Alternatively, a simpler way might be to push a 2.19.2(2) which simply reverts to the codebase of 2.19.1. This should might a smooth experience with little efford. The downside would be, that it would incorrectly imply this git-for-windows version would be based on git version 2.19.2.

[dscho]

Alternatively, a simpler way might be to push a 2.19.2(2) which simply reverts to the codebase of 2.19.1.

Are you going to do the work?

It's not as simple BTW as "revert the code base to v2.19.1". Git for Windows bundles many other components, e.g. OpenSSL. And that OpenSSL package in particular is a problem here, as it is a pretty steep upgrade from v1.0.2p to v1.1.1a, and for technical reasons, we still have to ship the v1.0.2p .dll files, even if git.exe does not link against them.

I understand that this comment was meant to be helpful. Unfortunately, in this instance it was particularly not so... :-(