Git for Windows updater performs an automatic restart without confirmation

[antidamage]

• I was not able to find an open or closed issue matching what I'm seeing

Setup

• Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

$ git --version --build-options
git version 2.26.2.windows.1
cpu: x86_64
built from commit: 4267c88
sizeof-long: 4
sizeof-size_t: 8

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

$ cmd.exe /c ver
Microsoft Windows [Version 10.0.18362.778]

• What options did you set as part of the installation? Or did you choose the
  defaults?
  Used previously set options, "only show new options" was selected, no options changed.

One of the following:

type "C:\Program Files\Git\etc\install-options.txt"
type "C:\Program Files (x86)\Git\etc\install-options.txt"
type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

None of those locations exist.

• Any other interesting things about your environment that might be related
  to the issue you're seeing?

Pretty much default Git config.

Details

• Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

Standard Git for Windows updater. It performed the update and restarted without prompting. It should definitely prompt before doing this.

[rimrul]

I'm pretty certain it does not reboot without asking for confirmation. Could you please check the event log for reboot event messages?

[qhill]

It appeared to do this for me too yesterday.

[rimrul]

You're actually correct.

As of git-for-windows/build-extra@e119d03 we pass /VERYSILENT to the installer without /NORESTART. That's not ideal.

[dscho]

As of git-for-windows/build-extra@e119d03 we pass /VERYSILENT to the installer without /NORESTART. That's not ideal.

Whoa! I'll fix this right away.

[dscho]

The next snapshot will have this fix.

Please note that it matters only (at least as far as I can tell) when the files Git for Windows' installer wants to overwrite or delete are still in use.

This could be a background job such as the GPG agent, of course...

[antidamage]

The problem still exists, it just did it again with the latest update with the default installer selections.

I'm not seeing any reboot events in the event log, although I'm pretty unfamiliar with finding stuff in it.

[rimrul]

If you updated from a 2.26.x release, you've just got the fixed updater with this update. The reboot is caused by the version you're upgrading from.

[dscho]

@antidamage sorry for the trouble; I think @rimrul's analysis is spot on, and there was simply no way we could fix the script, not without an upgrade, the same upgrade which of course triggers the very same bug again.

Please note that this was likely due to the script being run while a process was still using Git for Windows' files (e.g. a Git Bash). This is really unfortunate, but as I said, I do not know that we had any way to fix this without triggering the bug just once more (except by strongly suggesting to close all Git for Windows processes before upgrading; I could have done a better job trying to communicate that).