Skip to content

[Outreachy] config support for allowEmpty in commit#1902

Closed
tanushree27 wants to merge 1 commit into
git-for-windows:masterfrom
tanushree27:allow-empty-commit-config
Closed

[Outreachy] config support for allowEmpty in commit#1902
tanushree27 wants to merge 1 commit into
git-for-windows:masterfrom
tanushree27:allow-empty-commit-config

Conversation

@tanushree27
Copy link
Copy Markdown

@tanushree27 tanushree27 commented Oct 27, 2018

This commit is for issue #1854. Added support for allowEmpty commit attribute in configuration.

@tanushree27 tanushree27 mentioned this pull request Oct 27, 2018
Closed
@tanushree27 tanushree27 changed the title config support for allowEmpty in commit [Outreachy] config support for allowEmpty in commit Oct 27, 2018
simon-p-r
simon-p-r reviewed Oct 27, 2018
View reviewed changes
Comment thread Documentation/config.txt Outdated
PhilipOakley
PhilipOakley reviewed Oct 27, 2018
View reviewed changes
Copy link
Copy Markdown

@PhilipOakley PhilipOakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will be going upstream as a patch once it has had a first review.

It is worth getting started on the patch submission process ('format-patch' and 'send-email'), first to yourself, and then to the main Git List, so that they also see the 'open' discussions and it let's them feel that they helped ;-)

Comment thread Documentation/config.txt Outdated
Comment thread Documentation/git-commit.txt Outdated
@dscho
Copy link
Copy Markdown
Member

dscho commented Oct 31, 2018

It is worth getting started on the patch submission process ('format-patch' and 'send-email'), first to yourself, and then to the main Git List, so that they also see the 'open' discussions and it let's them feel that they helped ;-)

We tried to make that easier via this document: https://github.com/git-for-windows/git/blob/master/CONTRIBUTING.md

dscho
dscho requested changes Oct 31, 2018
View reviewed changes
Comment thread builtin/commit.c Outdated
Comment thread Documentation/config.txt Outdated
Comment thread Documentation/config.txt Outdated
Comment thread builtin/commit.c Outdated
Comment thread builtin/commit.c Outdated
Comment thread Documentation/config.txt Outdated
Comment thread Documentation/git-commit.txt Outdated
Comment thread Documentation/git-commit.txt Outdated
tanushree27
tanushree27 commented Nov 2, 2018
View reviewed changes
Comment thread builtin/commit.c Outdated
dscho
dscho requested changes Nov 5, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

Comment thread t/t7500-commit.sh Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

Comment thread Documentation/git-commit.txt Outdated
@weekly-digest weekly-digest Bot mentioned this pull request Nov 11, 2018
Closed
@tanushree27
commit: add a commit.allowEmpty config variable
be97f73 
when we cherrypick an existing commit it doesn't change anything and
therefore it fails prompting to reset (skip commit) or commit using
--allow-empty attribute and then continue.

Add commit.allowEmpty configuration variable as a convenience to skip
this process.

Add tests to check the behavior introduced by this commit.

This closes #1854

Signed-off-by: tanushree27 <tanushreetumane@gmail.com>
@weekly-digest weekly-digest Bot mentioned this pull request Nov 18, 2018
Closed
@dscho
Copy link
Copy Markdown
Member

dscho commented Nov 30, 2018

For the record, this patch has been contributed to the Git mailing list and can be viewed here: https://public-inbox.org/git/20181103112535.5730-1-tanushreetumane@gmail.com/#r

@tanushree27 I think what ended up as consensus was that the original reporter had an XY problem (i.e. they thought they needed X but they really needed Y): instead of allowing empty commits by default, what they need is to skip now-empty commits in git cherry-pick <commit-range>.

While this would be another fun project, it cannot reuse any of your work in this here PR, unfortunately.

So maybe close this PR?

@tanushree27
Copy link
Copy Markdown
Author

tanushree27 commented Nov 30, 2018

Closed.
Yes, unfortunately we cannot reuse this. But I did learn to add a custom config. :)

@dscho
Copy link
Copy Markdown
Member

dscho commented Nov 30, 2018

I did learn to add a custom config.

Yep! And you learned to find your way around Git's code base. All good things.

@chucklu
Copy link
Copy Markdown

chucklu commented Feb 27, 2019

@tanushree27 Sorry, I mistook the options I wanted in description of #1854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dscho dscho dscho requested changes

+2 more reviewers

@PhilipOakley PhilipOakley PhilipOakley left review comments

@simon-p-r simon-p-r simon-p-r left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tanushree27 @dscho @chucklu @PhilipOakley @simon-p-r