[fix] Gitk fails to open on a bare Git repository on Windows#2549
Merged
Conversation
Running 'git rev-parse --show-toplevel' fails on a bare git repo. This causes gitk to fail to startup. Signed-off-by: Remy Bohmer <github@bohmer.net>
dscho
requested changes
Mar 20, 2020
Member
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
Good catch. I have only minor concerns (which may not even need code changes but only answers to be addressed).
Thank you for opening this PR!
dscho
added a commit
that referenced
this pull request
Apr 17, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
dscho
added a commit
that referenced
this pull request
Apr 17, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 17, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
dscho
added a commit
that referenced
this pull request
Apr 18, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Apr 20, 2020
A recent regression in `gitk` that prevented it from running in bare repositories [has been fixed](git-for-windows/git#2549). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 20, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 20, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 20, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
derrickstolee
pushed a commit
to microsoft/git
that referenced
this pull request
Apr 20, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 21, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
dscho
added a commit
that referenced
this pull request
Apr 21, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 22, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 22, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
dscho
added a commit
that referenced
this pull request
Apr 22, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
dscho
added a commit
that referenced
this pull request
Apr 22, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 30, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 3, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 6, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 7, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 8, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
dscho
added a commit
that referenced
this pull request
May 8, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
dscho
added a commit
that referenced
this pull request
May 8, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 9, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 9, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 9, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 10, 2020
[fix] Gitk fails to open on a bare Git repository on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running 'git rev-parse --show-toplevel' fails on a bare git repo.
This causes gitk to fail to startup.
Signed-off-by: Remy Bohmer github@bohmer.net