mingw: improve performance of mingw_unlink()#2589
Merged
jeffhostetler merged 1 commit intoApr 20, 2020
Merged
Conversation
Update mingw_unlink() to first try to delete the file with existing permissions before trying to force it. Windows throws an error when trying to delete a read-only file. The mingw_unlink() compatibility wrapper always tries to _wchmod(666) the file before calling _wunlink() to avoid that error. However, since most files in the worktree are already writable, this is usually wasted effort. Update mingw_unlink() to just call DeleteFileW() directly and if that succeeds return. If that fails, fall back into the existing code path to update the permissions and use _wunlink() to get the existing error code mapping. Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
dscho
approved these changes
Apr 18, 2020
Member
@jeffhostetler I think we should do both. Are you totally opposed to having it in Git for Windows early? It's such a trivial patch, it will be simply skipped from the rebase once it arrives in any official Git version. |
Author
|
@dscho I’m ok with including in both. i was just trying to not cause you more work later. i’ll update and merge this and send one to GGG and the list on monday. thanks. |
Member
|
Excellent! |
|
@jeffhostetler any reason you didn't create a PR against |
derrickstolee
approved these changes
Apr 20, 2020
dscho
approved these changes
Apr 20, 2020
jeffhostetler
changed the title
Author
|
@derrickstolee I'll merge this into GFW as is. Then cherry-pick it into vfs so we can test it there. And then send a patch to the mailing list via GGG. |
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Apr 20, 2020
Worktree updates (e.g. `git checkout`, `git reset --hard`) [got a performance boost in sparse checkouts](git-for-windows/git#2589). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 20, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 20, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 20, 2020
mingw: improve performance of mingw_unlink()
derrickstolee
pushed a commit
to microsoft/git
that referenced
this pull request
Apr 20, 2020
…f-gfw mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 21, 2020
mingw: improve performance of mingw_unlink()
dscho
pushed a commit
that referenced
this pull request
Apr 21, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 3, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 6, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 7, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 8, 2020
mingw: improve performance of mingw_unlink()
dscho
pushed a commit
that referenced
this pull request
May 8, 2020
mingw: improve performance of mingw_unlink()
dscho
pushed a commit
that referenced
this pull request
May 8, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 9, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 9, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 9, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 10, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 10, 2020
mingw: improve performance of mingw_unlink()
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 11, 2020
mingw: improve performance of mingw_unlink()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update mingw_unlink() to first try to delete the file with existing
permissions before trying to force it.
Windows throws an error when trying to delete a read-only file. The
mingw_unlink() compatibility wrapper always tries to _wchmod(666) the
file before calling _wunlink() to avoid that error. However, since
most files in the worktree are already writable, this is usually
wasted effort.
Update mingw_unlink() to just call DeleteFileW() directly and if that
succeeds return. If that fails, fall back into the existing code path
to update the permissions and use _wunlink() to get the existing
error code mapping.
Signed-off-by: Jeff Hostetler jeffhost@microsoft.com