deploy(playwright): work around externally-enforced HTTPS#1899
Merged
ttaylorr merged 1 commit intogit:gh-pagesfrom Oct 7, 2024
Merged
deploy(playwright): work around externally-enforced HTTPS#1899ttaylorr merged 1 commit intogit:gh-pagesfrom
ttaylorr merged 1 commit intogit:gh-pagesfrom
Conversation
It is possible to enforce HTTPS on GitHub Pages, via https://docs.github.com/en/pages/getting-started-with-github-pages/securing-your-github-pages-site-with-https#enforcing-https-for-your-github-pages-site Without this flag enabled, it is still possible to access the site via http:// URLs, otherwise such URLs will automatically redirect to https:// URLs. However, it is also possible to enforce HTTPS e.g. by using a custom domain and putting Cloudflare in front of GitHub Pages. The Playwright tests, which are designed to catch undesired redirects that may, say, drop the `/git-scm.com/` part of the URLs in forks by mistake, are currently not expecting this. Since GitHub Pages supports HTTPS in all cases, and there are no options anywhere to enforce HTTP instead of HTTPS, let's just test with the https:// URL even if no enforcement was configured. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
Author
|
Unfortunately, this broke regular deployments (because the certificate is apparently unliked): 2024-10-07T15:10:18.7803921Z 1) [chrome] › git-scm.spec.js:25:1 › generator is Hugo ─────────────────────────────────────────── I'll fix it. |
Member
Author
d4f88c1 is the fix (and the commit message contains a bit of context to understand why http://git-scm.com/ (and that URL only) needs to be special-cased. |
Member
Author
|
And 0340ff6 is the fix for the fix ;-) The deployment worked now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Runs the Playwright tests using the https:// URL, always, even if http:// would be possible.
Context
It is possible to enforce HTTPS on GitHub Pages, via https://docs.github.com/en/pages/getting-started-with-github-pages/securing-your-github-pages-site-with-https#enforcing-https-for-your-github-pages-site
Without this flag enabled, it is still possible to access the site via http:// URLs, otherwise such URLs will automatically redirect to https:// URLs.
However, it is also possible to enforce HTTPS e.g. by using a custom domain and putting Cloudflare in front of GitHub Pages.
The Playwright tests, which are designed to catch undesired redirects that may, say, drop the
/git-scm.com/part of the URLs in forks by mistake, are currently not expecting this.Since GitHub Pages supports HTTPS in all cases, and there are no options anywhere to enforce HTTP instead of HTTPS, let's just test with the https:// URL even if no enforcement was configured.
This supersedes #1898.