add https://cln.network token base CLN by leonprou · Pull Request #1491 · gitcoinco/web

leonprou · 2018-06-17T08:04:30Z

Description

Add CLN token (ERC20). links: https://cln.network, https://www.colu.com

Checklist

linter status: 100% pass
changes don't break existing behavior
commit message follows commit guidelines

Affected core subsystem(s)

dashboard
crypto

Testing

Based my PR on this #155

leonprou · 2018-06-17T08:10:05Z

I think there's a problem with master..

owocki · 2018-06-17T14:24:02Z

      { 'addr': '0x2941deaad71adb02b944bd38ebce2f1f4c9a62dc', 'name': 'COLO', 'decimals': 18 },
-      { 'addr': '0xeccb46ebe07c5a2b249586796f921ddfe0d46271', 'name': 'GIT', 'decimals': 18 }
+      { 'addr': '0xeccb46ebe07c5a2b249586796f921ddfe0d46271', 'name': 'GIT', 'decimals': 18 },
+      { 'addr': '0x41C9d91E96b933b74ae21bCBb617369CBE022530', 'name': 'CLN', 'decimals': 18 }


this is ropsten is the address the same on ropsten as it is mainnet?

owocki · 2018-06-17T14:24:50Z

-    {'addr': '0x4CEdA7906a5Ed2179785Cd3A40A69ee8bc99C466', 'name': 'AION', 'decimals': 8},
+    {"addr": "0x09617f6fd6cf8a71278ec86e23bbab29c04353a7", "name": "ULT", "decimals": 18},
+    {"addr": "0x4CEdA7906a5Ed2179785Cd3A40A69ee8bc99C466", "name": "AION", "decimals": 8},
+    {"addr": "0x4162178B78D6985480A308B2190EE5517460406D", "name": "CLN", "decimals": 18}


sorrry to be pedantic, but can you add a trailing comma to each of these lines so a future token adder won't have to edit your line to add their token?

owocki · 2018-06-17T14:25:10Z

      { 'addr': '0x0000000000000000000000000000000000000000', 'name': 'ETH', 'decimals': 18, 'priority': 999 },
      { 'addr': '0x2941deaad71adb02b944bd38ebce2f1f4c9a62dc', 'name': 'COLO', 'decimals': 18 },
-      { 'addr': '0xeccb46ebe07c5a2b249586796f921ddfe0d46271', 'name': 'FOO', 'decimals': 18 }
+      { 'addr': '0xeccb46ebe07c5a2b249586796f921ddfe0d46271', 'name': 'FOO', 'decimals': 18 },


same qeustion as below on ropsten

@owocki no problem, it makes much easier to view the changes.
but now I've got a linting error and so I can't merge :(. Add a rule exception for that file?

owocki · 2018-06-17T14:27:05Z

created this for the test errors #1492

stickler-ci · 2018-06-17T14:41:21Z

      { 'addr': '0x09617f6fd6cf8a71278ec86e23bbab29c04353a7', 'name': 'ULT', 'decimals': 18 },
-      {'addr': '0x4CEdA7906a5Ed2179785Cd3A40A69ee8bc99C466', 'name': 'AION', 'decimals': 8}
+      { 'addr': '0x4CEdA7906a5Ed2179785Cd3A40A69ee8bc99C466', 'name': 'AION', 'decimals': 8 },
+      { 'addr': '0x4162178B78D6985480A308B2190EE5517460406D', 'name': 'CLN', 'decimals': 18 },


Unexpected trailing comma. (comma-dangle)

stickler-ci · 2018-06-17T14:41:21Z

      { 'addr': '0x2941deaad71adb02b944bd38ebce2f1f4c9a62dc', 'name': 'COLO', 'decimals': 18 },
-      { 'addr': '0xeccb46ebe07c5a2b249586796f921ddfe0d46271', 'name': 'FOO', 'decimals': 18 }
+      { 'addr': '0xeccb46ebe07c5a2b249586796f921ddfe0d46271', 'name': 'FOO', 'decimals': 18 },
+      { 'addr': '0x41C9d91E96b933b74ae21bCBb617369CBE022530', 'name': 'CLN', 'decimals': 18 },


Unexpected trailing comma. (comma-dangle)

stickler-ci · 2018-06-17T14:41:21Z

      {'addr': '0x09617f6fd6cf8a71278ec86e23bbab29c04353a7', 'name': 'ULT', 'decimals': 18},
-      {'addr': '0x4CEdA7906a5Ed2179785Cd3A40A69ee8bc99C466', 'name': 'AION', 'decimals': 8}
+      {'addr': '0x4CEdA7906a5Ed2179785Cd3A40A69ee8bc99C466', 'name': 'AION', 'decimals': 8},
+      {'addr': '0x4162178B78D6985480A308B2190EE5517460406D', 'name': 'CLN', 'decimals': 18},


Unexpected trailing comma. (comma-dangle)

stickler-ci · 2018-06-17T14:41:22Z

      { 'addr': '0x2941deaad71adb02b944bd38ebce2f1f4c9a62dc', 'name': 'COLO', 'decimals': 18 },
-      { 'addr': '0xeccb46ebe07c5a2b249586796f921ddfe0d46271', 'name': 'GIT', 'decimals': 18 }
+      { 'addr': '0xeccb46ebe07c5a2b249586796f921ddfe0d46271', 'name': 'GIT', 'decimals': 18 },
+      { 'addr': '0x41C9d91E96b933b74ae21bCBb617369CBE022530', 'name': 'CLN', 'decimals': 18 },


Unexpected trailing comma. (comma-dangle)

owocki · 2018-06-18T18:43:52Z

ahhh i didnt realize that would trip up the linter. my b.

@mbeacom are you okay with an exception for the linter error?

@leonprou when are you looking to ship your first bounty in this token? just trying to gauge your sense of urgency here. sorry this is taking a few days.

codecov · 2018-06-18T21:42:44Z

Codecov Report

❗ No coverage uploaded for pull request base (master@3dc8c66). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1491   +/-   ##
=========================================
  Coverage          ?   28.31%           
=========================================
  Files             ?      125           
  Lines             ?     9233           
  Branches          ?     1188           
=========================================
  Hits              ?     2614           
  Misses            ?     6522           
  Partials          ?       97

Impacted Files	Coverage Δ
app/dashboard/tokens.py	`100% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dc8c66...25b76ac. Read the comment docs.

leonprou · 2018-06-19T07:29:06Z

@owocki Hey, been off for a day. I see you already merged and it's even deployed 😄 , So all suberb 👍

owocki reviewed Jun 17, 2018

View reviewed changes

add https://cln.network token base CLN

0e84d35

leonprou force-pushed the add_cln_token branch from 34a521d to 0e84d35 Compare June 17, 2018 14:40

stickler-ci reviewed Jun 17, 2018

View reviewed changes

SaptakS mentioned this pull request Jun 18, 2018

Fix pytest version #1495

Merged

3 tasks

Fixes js linting

25b76ac

ghost assigned SaptakS Jun 18, 2018

ghost added the in progress label Jun 18, 2018

owocki merged commit 809071d into gitcoinco:master Jun 18, 2018

ghost removed the in progress label Jun 18, 2018

Uh oh!

Conversation

leonprou commented Jun 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Affected core subsystem(s)

Testing

Uh oh!

leonprou commented Jun 17, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

owocki commented Jun 17, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

owocki commented Jun 18, 2018

Uh oh!

codecov Bot commented Jun 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

leonprou commented Jun 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

leonprou commented Jun 17, 2018 •

edited

Loading

codecov Bot commented Jun 18, 2018 •

edited

Loading

leonprou commented Jun 19, 2018 •

edited

Loading