forked from git/git
-
Notifications
You must be signed in to change notification settings - Fork 192
Upstream some more Git for Windows' patches #2195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dscho
wants to merge
12
commits into
gitgitgadget:master
Choose a base branch
from
dscho:upstream-some-more-git-for-windows-patches
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+153
−37
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fd594ff
mingw: include the Python parts in the build
dscho 47fc974
mingw: stop hard-coding `CC = gcc`
dscho 53f1fd5
mingw: drop the -D_USE_32BIT_TIME_T option
dscho ad96aed
mingw: only use -Wl,--large-address-aware for 32-bit builds
dscho d67201f
mingw: avoid over-specifying `--pic-executable`
dscho b49c42c
mingw: set the prefix and HOST_CPU as per MSYS2's settings
dscho b00d242
mingw: only enable the MSYS2-specific stuff when compiling in MSYS2
dscho 9de4ea7
mingw: rely on MSYS2's metadata instead of hard-coding it
dscho 60a2999
windows: skip linking `git-<command>` for built-ins
dscho 1dd6ac9
mingw: always define `ETC_*` for MSYS2 environments
dscho d44d05c
mingw: ensure valid CTYPE
dscho 679d1fd
mingw: allow `git.exe` to be used instead of the "Git wrapper"
dscho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -465,14 +465,8 @@ ifeq ($(uname_S),Windows) | |
| GIT_VERSION := $(GIT_VERSION).MSVC | ||
| pathsep = ; | ||
| # Assume that this is built in Git for Windows' SDK | ||
| ifeq (MINGW32,$(MSYSTEM)) | ||
| prefix = /mingw32 | ||
| else | ||
| ifeq (CLANGARM64,$(MSYSTEM)) | ||
| prefix = /clangarm64 | ||
| else | ||
| prefix = /mingw64 | ||
| endif | ||
| ifneq (,$(MSYSTEM)) | ||
| prefix = $(MINGW_PREFIX) | ||
| endif | ||
| # Prepend MSVC 64-bit tool-chain to PATH. | ||
| # | ||
|
|
@@ -524,7 +518,8 @@ ifeq ($(uname_S),Windows) | |
| NO_POSIX_GOODIES = UnfortunatelyYes | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Junio C Hamano wrote on the Git mailing list (how to reply to this email): "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> The "dashed form" has been officially deprecated in Git version 1.5.4,
> which was released on February 2nd, 2008, i.e. a very long time ago.
> This deprecation was never finalized by skipping these hard-links, but
> we can start the process now, in Git for Windows.
Good. Perhaps somebody (you do not have to volunteer) can champion
their removal from everywhere at Git 3.0 version boundary?
Thanks. |
||
| NATIVE_CRLF = YesPlease | ||
| DEFAULT_HELP_FORMAT = html | ||
| ifeq (/mingw64,$(subst 32,64,$(subst clangarm,mingw,$(prefix)))) | ||
| SKIP_DASHED_BUILT_INS = YabbaDabbaDoo | ||
| ifneq (,$(MINGW_PREFIX)) | ||
| # Move system config into top-level /etc/ | ||
| ETC_GITCONFIG = ../etc/gitconfig | ||
| ETC_GITATTRIBUTES = ../etc/gitattributes | ||
|
|
@@ -540,7 +535,9 @@ endif | |
| compat/win32/pthread.o compat/win32/syslog.o \ | ||
| compat/win32/trace2_win32_process_info.o \ | ||
| compat/win32/dirent.o | ||
| COMPAT_CFLAGS = -D__USE_MINGW_ACCESS -DDETECT_MSYS_TTY -DNOGDI -DHAVE_STRING_H -Icompat -Icompat/regex -Icompat/win32 -DSTRIP_EXTENSION=\".exe\" | ||
| COMPAT_CFLAGS = -D__USE_MINGW_ACCESS -DDETECT_MSYS_TTY \ | ||
| -DENSURE_MSYSTEM_IS_SET="\"$(MSYSTEM)\"" -DMINGW_PREFIX="\"$(patsubst /%,%,$(MINGW_PREFIX))\"" \ | ||
| -DNOGDI -DHAVE_STRING_H -Icompat -Icompat/regex -Icompat/win32 -DSTRIP_EXTENSION=\".exe\" | ||
| BASIC_LDFLAGS = -IGNORE:4217 -IGNORE:4049 -NOLOGO -ENTRY:wmainCRTStartup -SUBSYSTEM:CONSOLE | ||
| # invalidcontinue.obj allows Git's source code to close the same file | ||
| # handle twice, or to access the osfhandle of an already-closed stdout | ||
|
|
@@ -716,6 +713,7 @@ ifeq ($(uname_S),MINGW) | |
| FSMONITOR_DAEMON_BACKEND = win32 | ||
| FSMONITOR_OS_SETTINGS = win32 | ||
|
|
||
| SKIP_DASHED_BUILT_INS = YabbaDabbaDoo | ||
| RUNTIME_PREFIX = YesPlease | ||
| HAVE_WPGMPTR = YesWeDo | ||
| NO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease | ||
|
|
@@ -754,38 +752,33 @@ ifeq ($(uname_S),MINGW) | |
| ifneq (,$(findstring -O,$(filter-out -O0 -Og,$(CFLAGS)))) | ||
| BASIC_LDFLAGS += -Wl,--dynamicbase | ||
| endif | ||
| ifeq (MINGW32,$(MSYSTEM)) | ||
| prefix = /mingw32 | ||
| HOST_CPU = i686 | ||
| BASIC_LDFLAGS += -Wl,--pic-executable,-e,_mainCRTStartup | ||
| endif | ||
| ifeq (MINGW64,$(MSYSTEM)) | ||
| prefix = /mingw64 | ||
| HOST_CPU = x86_64 | ||
| BASIC_LDFLAGS += -Wl,--pic-executable,-e,mainCRTStartup | ||
| else ifeq (CLANGARM64,$(MSYSTEM)) | ||
| prefix = /clangarm64 | ||
| HOST_CPU = aarch64 | ||
| BASIC_LDFLAGS += -Wl,--pic-executable,-e,mainCRTStartup | ||
| else | ||
| COMPAT_CFLAGS += -D_USE_32BIT_TIME_T | ||
| BASIC_LDFLAGS += -Wl,--large-address-aware | ||
| ifneq (,$(MSYSTEM)) | ||
| ifeq ($(MINGW_PREFIX),$(filter-out /%,$(MINGW_PREFIX))) | ||
| # Override if empty or does not start with a slash | ||
| MINGW_PREFIX := /$(shell echo '$(MSYSTEM)' | tr A-Z a-z) | ||
| endif | ||
| prefix = $(MINGW_PREFIX) | ||
| HOST_CPU = $(patsubst %-w64-mingw32,%,$(MINGW_CHOST)) | ||
| BASIC_LDFLAGS += -Wl,--pic-executable | ||
| COMPAT_CFLAGS += -DDETECT_MSYS_TTY \ | ||
| -DENSURE_MSYSTEM_IS_SET="\"$(MSYSTEM)\"" \ | ||
| -DMINGW_PREFIX="\"$(patsubst /%,%,$(MINGW_PREFIX))\"" | ||
| ifeq (MINGW32,$(MSYSTEM)) | ||
| BASIC_LDFLAGS += -Wl,--large-address-aware | ||
| endif | ||
| # Move system config into top-level /etc/ | ||
| ETC_GITCONFIG = ../etc/gitconfig | ||
| ETC_GITATTRIBUTES = ../etc/gitattributes | ||
| endif | ||
| CC = gcc | ||
| COMPAT_CFLAGS += -D__USE_MINGW_ANSI_STDIO=0 -DDETECT_MSYS_TTY \ | ||
| -fstack-protector-strong | ||
| COMPAT_CFLAGS += -D__USE_MINGW_ANSI_STDIO=0 -fstack-protector-strong | ||
| EXTLIBS += -lntdll | ||
| EXTRA_PROGRAMS += headless-git$X | ||
| INSTALL = /bin/install | ||
| INTERNAL_QSORT = YesPlease | ||
| HAVE_LIBCHARSET_H = YesPlease | ||
| USE_GETTEXT_SCHEME = fallthrough | ||
| USE_LIBPCRE = YesPlease | ||
| ifeq (/mingw64,$(subst 32,64,$(subst clangarm,mingw,$(prefix)))) | ||
| # Move system config into top-level /etc/ | ||
| ETC_GITCONFIG = ../etc/gitconfig | ||
| ETC_GITATTRIBUTES = ../etc/gitattributes | ||
| endif | ||
| NO_PYTHON = | ||
| endif | ||
| ifeq ($(uname_S),QNX) | ||
| COMPAT_CFLAGS += -DSA_RESTART=0 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Junio C Hamano wrote on the Git mailing list (how to reply to this email):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Johannes Schindelin wrote on the Git mailing list (how to reply to this email):