feat: support GitHub enterprise api#197
Merged
jmeridth merged 8 commits intogithub-community-projects:mainfrom Oct 30, 2024
Merged
feat: support GitHub enterprise api#197jmeridth merged 8 commits intogithub-community-projects:mainfrom
jmeridth merged 8 commits intogithub-community-projects:mainfrom
Conversation
jmeridth
reviewed
Oct 28, 2024
Collaborator
jmeridth
left a comment
There was a problem hiding this comment.
Couple things. This looks great. Thank you for the PR.
5 tasks
jmeridth
previously approved these changes
Oct 29, 2024
auto-merge was automatically disabled
October 29, 2024 09:34
Head branch was pushed to by a user without write access
jmeridth
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
This Pull request is based on the already merged github/evergreen#256 to give support to GitHub Enterprise login using a GitHub App also created on GitHub Enterprise
Apart of the necessary changes on the
auth.pyfile to support this feature, some minor changes were added to this PR, the.coveragercfile was also added to ignore test files for code coverage, with this change the code coverage went below 80% so a few more tests were added.Code coverage
Tested against a repository on GHE enterprise the code created a
contributors.jsonandcontributors.mdfileReadiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
bug,documentation,enhancement,infrastructure,maintenanceorbreaking