Skip to content

Split Fortran into fixed and free source by file extension#4753

Merged
lildude merged 5 commits into
github-linguist:masterfrom
ararslan:aa/fortran-redux
May 27, 2020
Merged

Split Fortran into fixed and free source by file extension#4753
lildude merged 5 commits into
github-linguist:masterfrom
ararslan:aa/fortran-redux

Conversation

@ararslan
Copy link
Copy Markdown
Contributor

@ararslan ararslan commented Dec 18, 2019

This permits applying a different tm_scope for modern Fortran.

Description

Currently all Fortran files are recognized as fixed-source (think FORTRAN 77 style), which is provided by the TextMate bundle as source.fortran. However, the old style really only applies for a few file extensions. Instead, we can do as @pchaigno suggested and split the definitions into two "dialects" sharing a common group, one for fixed-source and one for free-source (i.e. modern).

Checklist:

  • I am fixing a misclassified language
    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.

I'll need a bit of guidance for completing the checklist here.

EDIT: Meant to make this a draft PR.

Fixes #4799...?

This permits applying a different tm_scope for modern Fortran.
Copy link
Copy Markdown
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with Fortran, but I'm wondering if the hassle over syntax highlighting can be resolved with a carefully crafted grammar that can recognise both dialects. From what I've read here, though, that mightn't be easy.

In either case, I'm okay with the split, provided the issues I mentioned are addressed.

Comment thread lib/linguist/languages.yml
Comment thread lib/linguist/languages.yml Outdated
Comment thread lib/linguist/languages.yml
Comment thread lib/linguist/languages.yml Outdated
@stale
Copy link
Copy Markdown

stale Bot commented Jan 19, 2020

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale Bot added the Stale label Jan 19, 2020
@stale stale Bot removed the Stale label Jan 19, 2020
@lildude lildude removed their assignment Jan 23, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Mar 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale Bot added the Stale label Mar 21, 2020
@lildude lildude removed the Stale label Mar 21, 2020
@jacobwilliams
Copy link
Copy Markdown

Still needed. The broken version is still being used on GitHub.

@ararslan
Copy link
Copy Markdown
Contributor Author

Sorry, I just haven't had time to revisit this. If you'd like to take a stab at it, please feel free to base your work off of this branch if it would help.

@stale
Copy link
Copy Markdown

stale Bot commented Apr 23, 2020

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale Bot added the Stale label Apr 23, 2020
@ararslan
Copy link
Copy Markdown
Contributor Author

Still relevant but still no time to revisit.

@stale stale Bot removed the Stale label Apr 23, 2020
@stale
Copy link
Copy Markdown

stale Bot commented May 23, 2020

This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions.

@stale stale Bot added the Stale label May 23, 2020
@ararslan
Copy link
Copy Markdown
Contributor Author

Same deal

@stale stale Bot removed the Stale label May 24, 2020
@lildude
Copy link
Copy Markdown
Member

lildude commented May 27, 2020

I'll pick this up and implement my suggestion.

@lildude
Copy link
Copy Markdown
Member

lildude commented May 27, 2020

🎉 all done.

@lildude lildude requested review from Alhadis and pchaigno May 27, 2020 09:33
@lildude lildude merged commit 0ed5976 into github-linguist:master May 27, 2020
@lildude
Copy link
Copy Markdown
Member

lildude commented May 27, 2020

For those watching this, I won't be able to make a release until after 2 Jun, so these changes won't appear on GitHub.com until probably the week after at the earliest.

@ararslan ararslan deleted the aa/fortran-redux branch May 27, 2020 16:25
@ararslan
Copy link
Copy Markdown
Contributor Author

Thanks so much for getting this over the finish line, I really appreciate it!

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

F90 File syntax highlighting broken?

5 participants