Split Fortran into fixed and free source by file extension#4753
Conversation
This permits applying a different tm_scope for modern Fortran.
Alhadis
left a comment
There was a problem hiding this comment.
I'm not familiar with Fortran, but I'm wondering if the hassle over syntax highlighting can be resolved with a carefully crafted grammar that can recognise both dialects. From what I've read here, though, that mightn't be easy.
In either case, I'm okay with the split, provided the issues I mentioned are addressed.
|
This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions. |
|
Still needed. The broken version is still being used on GitHub. |
|
Sorry, I just haven't had time to revisit this. If you'd like to take a stab at it, please feel free to base your work off of this branch if it would help. |
|
This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions. |
|
Still relevant but still no time to revisit. |
|
This pull request has been automatically marked as stale because it has not had recent activity, and will be closed if no further activity occurs. If this pull request was overlooked, forgotten, or should remain open for any other reason, please reply here to call attention to it and remove the stale status. Thank you for your contributions. |
|
Same deal |
|
I'll pick this up and implement my suggestion. |
|
🎉 all done. |
|
For those watching this, I won't be able to make a release until after 2 Jun, so these changes won't appear on GitHub.com until probably the week after at the earliest. |
|
Thanks so much for getting this over the finish line, I really appreciate it! |
This permits applying a different
tm_scopefor modern Fortran.Description
Currently all Fortran files are recognized as fixed-source (think FORTRAN 77 style), which is provided by the TextMate bundle as
source.fortran. However, the old style really only applies for a few file extensions. Instead, we can do as @pchaigno suggested and split the definitions into two "dialects" sharing a commongroup, one for fixed-source and one for free-source (i.e. modern).Checklist:
I'll need a bit of guidance for completing the checklist here.
EDIT: Meant to make this a draft PR.
Fixes #4799...?