Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
482d710
Add VsTippingService for callout notifications
jcansdale Oct 18, 2018
e25a915
Example: show tip when user changes GitHub repo
jcansdale Oct 18, 2018
053b6ec
Show callout when repository has no origin remote
jcansdale Nov 9, 2018
10d2f24
Rename IVsTippingService to ITippingService
jcansdale Nov 9, 2018
496cddd
Add view for when there is no origin remote
jcansdale Nov 9, 2018
40273b7
Move HasNoRemoteOrigin logic to GitService
jcansdale Nov 9, 2018
da21ea7
Rename NoOriginRemote to NoRemoteOrigin
jcansdale Nov 9, 2018
1fe4009
Split GitService unit and integration tests
jcansdale Nov 12, 2018
023f693
Add test for when there's no repository
jcansdale Nov 12, 2018
835ebb1
Fix CreateLocalRepositoryModel when no repository
jcansdale Nov 12, 2018
1d9563e
Add HasNoRemoteOrigin tests
jcansdale Nov 12, 2018
8c8ddca
Add no directory test
jcansdale Nov 12, 2018
5f98e7b
Merge branch 'master' into fixes/1729-warn-when-no-origin
jcansdale Nov 12, 2018
7348ae2
Fix type does not support direct content in XAML
jcansdale Nov 12, 2018
32e4df3
Add resource text for no "origin" message
jcansdale Nov 12, 2018
77a6176
Add TrackedRemoteName to BranchModel
jcansdale Nov 12, 2018
545627b
Fix issue when changing to repo with no CloneUrl
jcansdale Nov 13, 2018
cb7b1e2
Add test project for GitHub.Services.Vssdk
jcansdale Nov 13, 2018
04833b9
Add first test for TippingService
jcansdale Nov 13, 2018
0b7c421
Don't throw if VsTippingService API has changed
jcansdale Nov 13, 2018
600c9de
Check arguments passed to RequestCalloutDisplay
jcansdale Nov 13, 2018
d6f5107
Add xmldoc comments for TippingService
jcansdale Nov 13, 2018
ccebc24
Rename HasNoRemoteOrigin to HasRemotesButNoOrigin
jcansdale Nov 13, 2018
fb1c337
Add button to Edit Remotes
jcansdale Nov 14, 2018
35ab556
Add some explanatory text [wip]
jcansdale Nov 14, 2018
d352010
Merge branch 'master' into fixes/1729-warn-when-no-origin
jcansdale Nov 15, 2018
a4eb753
Remove redundant OnEditRemotesAsync
jcansdale Nov 21, 2018
a7d80b3
Use named args instead of vars
jcansdale Nov 21, 2018
8c4852f
Don't copy parameter types from current method
jcansdale Nov 21, 2018
13ba3f2
Find RequestCalloutDisplay on IVsTippingService
jcansdale Nov 21, 2018
b7fcf23
Name Guids for RepositorySettings / Remotes
jcansdale Nov 21, 2018
f895926
Use Rx to wait for IsLoaded==true
jcansdale Nov 21, 2018
7e51779
Fix null reference exception in Visual Studio 2015
jcansdale Nov 22, 2018
222f635
Don't throw when changing to non-Git solution
jcansdale Nov 22, 2018
5ff428f
Log any exceptions thrown by NoRemoteOriginCallout
jcansdale Nov 22, 2018
01abce3
Locate IVsTippingService using COM Guid
jcansdale Nov 26, 2018
436c3c6
Remove unused code
jcansdale Nov 26, 2018
8fd31a6
Make reflection code more robust
jcansdale Nov 26, 2018
a22bf5e
Merge branch 'master' into fixes/1729-warn-when-no-origin
jcansdale Nov 26, 2018
9f328eb
Merge branch 'master' into fixes/1729-warn-when-no-origin
jcansdale Nov 28, 2018
f755319
Move must have origin text to resource
jcansdale Nov 28, 2018
1e789ed
Merge branch 'master' into fixes/1729-warn-when-no-origin
jcansdale Nov 29, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix CreateLocalRepositoryModel when no repository
  • Loading branch information
jcansdale committed Nov 12, 2018
commit 835ebb131d2f0e2bfafe2cf6098a2203e19328e6
10 changes: 8 additions & 2 deletions src/GitHub.Exports/Services/GitService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,14 @@ public LocalRepositoryModel CreateLocalRepositoryModel(string localPath)

using (var repository = GetRepository(localPath))
{
var cloneUrl = GetUri(repository);
var noRemoteOrigin = HasNoRemoteOrigin(repository);
UriString cloneUrl = null;
bool noRemoteOrigin = false;
if (repository != null)
{
cloneUrl = GetUri(repository);
noRemoteOrigin = HasNoRemoteOrigin(repository);
}

var name = cloneUrl?.RepositoryName ?? dir.Name;

var model = new LocalRepositoryModel
Expand Down