Skip to content

Include request IDs in errors when available. #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisgavin merged 4 commits into from
Jun 14, 2022
Merged

Include request IDs in errors when available. #72

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9a5e079
Include request IDs in errors when available.
chrisgavin May 30, 2022
410478b
Fix a typo.
chrisgavin Jun 14, 2022
c4a0514
Remove a change meant for another PR.
chrisgavin Jun 14, 2022
3fd082e
Merge main into better-http-errors.
chrisgavin Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove a change meant for another PR.
  • Loading branch information
@chrisgavin
chrisgavin committed Jun 14, 2022
commit c4a05147c00efd8842644f52e4ed733efc044b03
26 changes: 0 additions & 26 deletions internal/push/push.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,32 +246,6 @@ func (pushService *pushService) pushGit(repository *github.Repository, initialPu
Auth: credentials,
Progress: os.Stderr,
})
if err != nil && strings.Contains(err.Error(), "pre-receive hook declined") {
log.Warn("Push was rejected by a pre-receive hook. This may be because force-pushing is not allowed. Will try and remove and recreate the branch.")
if len(refSpecs) == 1 && refSpecs[0].String() == defaultBrachRefSpec {
// todo
}
negativeRefSpecs := []config.RefSpec{}
for _, refSpec := range refSpecs {
negativeRefSpecs = append(negativeRefSpecs, config.RefSpec(":"+refSpec.Src()))
err = remote.PushContext(pushService.ctx, &git.PushOptions{
RefSpecs: negativeRefSpecs,
Auth: credentials,
Progress: os.Stderr,
})
if err != nil {
return errors.Wrap(err, "Error removing existing refs.")
}
err = remote.PushContext(pushService.ctx, &git.PushOptions{
RefSpecs: refSpecs,
Auth: credentials,
Progress: os.Stderr,
})
if err != nil && errors.Cause(err) != git.NoErrAlreadyUpToDate {
return errors.Wrap(err, "Error pushing Action to GitHub Enterprise Server.")
}
}
}
if err != nil && errors.Cause(err) != git.NoErrAlreadyUpToDate {
return errors.Wrap(err, "Error pushing Action to GitHub Enterprise Server.")
}
Expand Down